Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add virtual_has_one for transformation_mapping for API accessibility #18070

Merged
merged 1 commit into from
Oct 10, 2018
Merged

Add virtual_has_one for transformation_mapping for API accessibility #18070

merged 1 commit into from
Oct 10, 2018

Conversation

AparnaKarve
Copy link
Contributor

@AparnaKarve AparnaKarve commented Oct 8, 2018 •
edited by simaishi
Loading

Expose the transformation_mapping in the API below -

api/service_templates?filter[]=type=ServiceTemplateTransformationPlan&attributes=transformation_mapping

With this change, we don't need a second API call in the UI.
Noticeable improvement in the Migration Plan list loading time

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1642611

@AparnaKarve AparnaKarve mentioned this pull request Oct 8, 2018
Merged
@AparnaKarve
Copy link
Contributor Author

@miq-bot add-label hammer/yes

@miq-bot assign @bzwei

@bzwei
Copy link
Contributor

bzwei commented Oct 10, 2018

@miq-bot assign @roliveri

@miq-bot miq-bot assigned roliveri and unassigned bzwei Oct 10, 2018
@blomquisg blomquisg merged commit 19b4199 into ManageIQ:master Oct 10, 2018
@AparnaKarve AparnaKarve deleted the virtual_transformation_mapping branch October 10, 2018 20:00
simaishi pushed a commit that referenced this pull request Oct 11, 2018
@blomquisg @simaishi
Merge pull request #18070 from AparnaKarve/virtual_transformation_map…
49dfa38 
…ping

Add `virtual_has_one` for `transformation_mapping` for API accessibility

(cherry picked from commit 19b4199)
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit 49dfa38096f24c4dd754ca949ffb41edddd961ea
Author: Greg Blomquist <blomquisg@gmail.com>
Date:   Wed Oct 10 15:43:12 2018 -0400

    Merge pull request #18070 from AparnaKarve/virtual_transformation_mapping
    
    Add `virtual_has_one` for `transformation_mapping` for API accessibility
    
    (cherry picked from commit 19b41993df1c260f922cb63b1ba82b3587f72d49)

@AparnaKarve
Copy link
Contributor Author

@miq-bot add_label gaprindashvili/yes

simaishi pushed a commit that referenced this pull request Nov 6, 2018
@blomquisg @simaishi
Merge pull request #18070 from AparnaKarve/virtual_transformation_map…
5124db7 
…ping

Add `virtual_has_one` for `transformation_mapping` for API accessibility

(cherry picked from commit 19b4199)

https://bugzilla.redhat.com/show_bug.cgi?id=1647108
@simaishi
Copy link
Contributor

simaishi commented Nov 6, 2018

Gaprindashvili backport details:

$ git log -1
commit 5124db781063cfe192d171dd1de5160e92cf905f
Author: Greg Blomquist <blomquisg@gmail.com>
Date:   Wed Oct 10 15:43:12 2018 -0400

    Merge pull request #18070 from AparnaKarve/virtual_transformation_mapping
    
    Add `virtual_has_one` for `transformation_mapping` for API accessibility
    
    (cherry picked from commit 19b41993df1c260f922cb63b1ba82b3587f72d49)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1647108

nizaminabeel pushed a commit to nizaminabeel/manageiq that referenced this pull request Dec 11, 2018
@blomquisg @nabeel-tariq
Merge pull request ManageIQ#18070 from AparnaKarve/virtual_transforma…
96fddd5 
…tion_mapping

Add `virtual_has_one` for `transformation_mapping` for API accessibility

(cherry picked from commit 19b4199)

https://bugzilla.redhat.com/show_bug.cgi?id=1647108
@mfeifer mfeifer added this to the Sprint 97 Ending Oct 22, 2018 milestone Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzwei bzwei bzwei approved these changes

Assignees

@roliveri roliveri

Labels
blocker gaprindashvili/backported hammer/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@AparnaKarve @bzwei @simaishi @blomquisg @roliveri @mfeifer @miq-bot