Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix Exception due to missing #merged_uri parameters in FileDepot parent class #18131
The #merged_uri method in FileDepot was added by a previous PR but it was
Fix the parent FileDepot class, and add tests in two derived classes -
Steps for Testing/QA
Schedule a DB backup on an NFS File Depot. It should not cause an exception.
@carbonin ok I changed the tests that had been there, passing in nil uri parameters that are ignored, which return the uri attribute set on the FileDepots. Also added another test that passes in a Swift URI to the NFS file depot, showing that the attribute set on the depot is the one passed back and not the parameter.
Oct 25, 2018
added a commit
this pull request
Oct 26, 2018
Hammer backport details: