[GAPRINDASHVILI] fixed saving tag name #18386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrudman
changed the title
|
closed in favor of #18387 |
yrudman
changed the title
|
@miq-bot remove-label hammer/yes |
yrudman
force-pushed
the
gaprindashvili-fixed-saving-tag-name
branch
from
5d2d95b
to
359f671
Compare
gtanzillo
reviewed
Jan 24, 2019
app/models/classification.rb
Outdated
| @@ -525,7 +525,12 @@ def find_tag | |||
| end | |||
|
|
|||
| def save_tag | |||
| self.tag = Tag.find_or_create_by_classification_name(name, region_id, ns, parent_id) | |||
| tag_name = Classification.name2tag(name, parent_id, ns) | |||
There was a problem hiding this comment.
Small nit but, couldn't this line be moved into the if block?
There was a problem hiding this comment.
sure, it is leftover from my "backporting" from master where tag_name used in else block too
|
Checked commits yrudman/manageiq@00a6a3c~...5512d1c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
gtanzillo
approved these changes
Jan 25, 2019
yrudman
added a commit
to yrudman/manageiq
that referenced
this pull request
Jan 29, 2019
simaishi
added a commit
that referenced
this pull request
Jan 29, 2019
…aving-tag-name" This reverts commit ac3a51e, reversing changes made to 5d837f5. https://bugzilla.redhat.com/show_bug.cgi?id=1668730
|
This is now reverted: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Editing tag name on existing record creates new record in Tag table
Fix: Do not create new record in Tag table when editing existing tag
Backport of #18378
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1668730
@miq-bot add-label core, bug, gaprindashvili/yes, hammer/yes