Fix: When user changing display timezone than some widgets show no data #18448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrudman
force-pushed
the
remove-timezone-filter-if-widget-content-not-found
branch
from
866da88
to
b8e2557
Compare
|
@miq-bot add-label hammer/yes |
yrudman
force-pushed
the
remove-timezone-filter-if-widget-content-not-found
branch
2 times, most recently
from
93a9cc2
to
b80ece6
Compare
yrudman
changed the title
|
\cc @gtanzillo @jrafanie |
yrudman
force-pushed
the
remove-timezone-filter-if-widget-content-not-found
branch
2 times, most recently
from
f30be94
to
2870643
Compare
|
@jrafanie could you review |
jrafanie
reviewed
Feb 18, 2019
jrafanie
reviewed
Feb 18, 2019
jrafanie
requested changes
Feb 18, 2019
yrudman
changed the title
yrudman
force-pushed
the
remove-timezone-filter-if-widget-content-not-found
branch
2 times, most recently
from
fad5dbc
to
281c8f5
Compare
yrudman
changed the title
jrafanie
reviewed
Feb 19, 2019
app/models/miq_widget.rb
Outdated
| contents ||= miq_widget_contents.find_by(conditions) | ||
|
|
||
| if contents.nil? | ||
| _log.warn("No contents found for Widget: `#{title}` Group: #{user.current_group.description} in Timezone '#{timezone}'. Attempting to get widget's contents from any Timezone ...") |
There was a problem hiding this comment.
I believe you want to use single quotes ', not backticks `
jrafanie
requested changes
Feb 19, 2019
…w Timezone was not generated yet and some widgets on dasgboard does not show any data since Timezone is present in condition. Fix: if contents with respect to Timezone not found than try to search for widgets content without Timezone filter. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1676584
…Timezone not found than remove Timezone from search and try to find contents again without specifying timezone
yrudman
force-pushed
the
remove-timezone-filter-if-widget-content-not-found
branch
from
281c8f5
to
80373b6
Compare
|
Checked commits yrudman/manageiq@1cc4672~...80373b6 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
jrafanie
approved these changes
Feb 20, 2019
yrudman
changed the title
yrudman
deleted the
remove-timezone-filter-if-widget-content-not-found
branch
simaishi
pushed a commit
that referenced
this pull request
Apr 23, 2019
…et-content-not-found When user changing display timezone than some widgets show no data (cherry picked from commit d6776df) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1702480
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: user's timezone is part of filter when searching for widget's content. So, when use changing display timezone than data disappears from widgets.
Fix: if widget's content for specific timezone not found than try to find content without specifying timezone
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1676584
@miq-bot add-label bug, reporting
BEFORE:
AFTER:
