Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add region checking for all user schedules #18512

Merged
merged 1 commit into from Mar 21, 2019
Merged

Conversation

ashybalka
Copy link
Contributor

User story:
I have master-slave architecture, with DB replication from slave to mater.
When the schedule runs on slave, it is update in the master db and the runner starts this schedule in master without checking region.

@miq-bot
Copy link
Member

miq-bot commented Mar 4, 2019

Checked commit ashybalka@d857e53 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

Copy link
Member

@Fryguy Fryguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrafanie can you review as well? I don't remember if schedules fall into that weird replication case like users and roles. Pretty sure they don't, and if not, then this is good.

Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this makes sense to me. Schedules are replicated and we don't want the global region schedule worker to run schedules for another region.

@jrafanie jrafanie merged commit 7e5f44c into ManageIQ:master Mar 21, 2019
@jrafanie jrafanie added this to the Sprint 108 Ending Apr 1, 2019 milestone Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants