Use string class name instead of hitting autoload #18629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEPRECATION WARNING: Passing a class to the `class_name` is deprecated and will raise an ArgumentError in Rails 5.2. It eagerloads more classes than necessary and potentially creates circular dependencies. Please pass the class name as a string: `has_many :public_network_routers, class_name: 'NetworkRouter'` (called from <class:CloudNetwork> at /Users/joerafaniello/Code/manageiq/app/models/cloud_network.rb:21)
jrafanie
commented
Apr 4, 2019
| @@ -1,7 +1,7 @@ | |||
| class ContainerGroupPerformance < MetricRollup | |||
| default_scope { where("resource_type = 'ContainerGroup' and resource_id IS NOT NULL") } | |||
|
|
|||
| belongs_to :container_group, :foreign_key => :resource_id, :class_name => ContainerGroup.name | |||
|
Checked commit jrafanie@b9bbb0d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 app/models/cloud_network.rb
app/models/container_group.rb
app/models/container_group_performance.rb
app/models/container_image.rb
app/models/container_node.rb
app/models/container_node_performance.rb
app/models/container_performance.rb
app/models/container_project_performance.rb
app/models/conversion_host.rb
app/models/notification.rb
|
|
Related to #18076 |
carbonin
approved these changes
Apr 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEPRECATION WARNING: Passing a class to the
class_nameis deprecatedand will raise an ArgumentError in Rails 5.2. It eagerloads more classes
than necessary and potentially creates circular dependencies. Please
pass the class name as a string:
has_many :public_network_routers, class_name: 'NetworkRouter'(called from class:CloudNetwork at/Users/joerafaniello/Code/manageiq/app/models/cloud_network.rb:21)
🤣 the branch name 🤣 cc @gtanzillo @Fryguy