Remove test for legacy MiqReport

[romanblanco]

Removed special handling of legacy MiqReport while importing

[miq-bot]

Checked commit romanblanco@1435fe3 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 1 offense detected

spec/models/miq_report/import_export_spec.rb

• ❗ - Line 21, Col 28 - Security/YAMLLoad - Prefer using YAML.safe_load over YAML.load.

[Fryguy]

Do we just not support legacy reports anymore via upgrade? Does it make sense to just have a migration to ensure this? (I'm not even sure how old this is...if it's older than, C-release I think (whatever the version you are forced to upgrade to), then this is probably ok.

cc @gtanzillo ?

[kbrock]

This commit 7c78517f3e2 is from 2013 via @lfu

I do remember running into this scenario years back, but can't place why.
Think it was a customer who had a yaml file with a number of reports in it.
Think maybe they were exporting the "shame" report?
(Sorry, not trying to be vague here. I just remember enjoying the name of the report. Of course the details elude me)

[chessbyte]

@Fryguy @kbrock what should we do with this PR?

[Fryguy]

Waiting on response from @gtanzillo

[gtanzillo]

To be honest, I'm not familiar with the issue that the "legacy report" check was meant to address. I do recall that in the distant past we had an issue with ActiveRecord objects that were serialized in report results and needed some special code to deal with then when the internal AR object format was changed. But this is in the report definition.

[kbrock]

The only concern I have is when we export a bunch of miq_reports in a single yaml file. I thought this was needed to import it back again.

That is the only use case I know of. I don't know how to export or import them, I just know we had this functionality within the past few years.

If that still works then I'm 👍

[kbrock]

this is here to support importing a yaml file with multiple reports in them. those seem to have the extra MiqReport nodes.

as long as we no longer support exporting all reports into a single yaml file, then this should be fine. I don't know the import/export parts well enough to verify my statement.

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.