[V2V] Add applying_right_sizing state to InfraConversionJob #19238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
|
Checked commits fabiendupont/manageiq@6be48fb~...5d6ae53 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@agrare You ok with this one? |
agrare
approved these changes
Sep 10, 2019
|
Hey sorry @fdupont-redhat this one slipped through I didn't notice it |
This was referenced Sep 10, 2019
ghost
deleted the
simaishi
pushed a commit
that referenced
this pull request
Nov 4, 2019
…_right_size [V2V] Add applying_right_sizing state to InfraConversionJob (cherry picked from commit 7a820ad) https://bugzilla.redhat.com/show_bug.cgi?id=1768522
|
Ivanchuk backport details: |
simaishi
added a commit
that referenced
this pull request
Dec 3, 2019
…ne_apply_right_size" This reverts commit bf50264. https://bugzilla.redhat.com/show_bug.cgi?id=1768522
|
Reverted the backport |
simaishi
pushed a commit
that referenced
this pull request
Feb 21, 2020
…_right_size [V2V] Add applying_right_sizing state to InfraConversionJob (cherry picked from commit 7a820ad) https://bugzilla.redhat.com/show_bug.cgi?id=1768522
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For IMS 1.3 we're moving state machine handling from automate into core. For ease of writing and review, we're breaking this down into (hopefully) easily digestible bits, one state at a time. Each PR will ultimately have a corresponding PR in manageiq-content that deletes the relevant bit of code from automate.
Original automate code:
https://github.com/ManageIQ/manageiq-content/blob/master/content/automate/ManageIQ/Transformation/Infrastructure/VM/Common.class/__methods__/applyrightsize.rb
This PR adds applying_right_sizing state to the state machine. The state machine is changed to allow transition from waiting_for_inventory_refresh.
RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1747927
Depends on #19149, #19150, #19154, #19177, #19200, #19216, #19222, #19230
Built on #19230