[V2V] Remove CheckVmInInventory state #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add-label transformation, refactoring, ivanchuk/yes |
Pull Request Test Coverage Report for Build 3520
💛 - Coveralls |
ghost
changed the title
ghost
mentioned this pull request
|
Checked commit fabiendupont@6777816 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
ghost
changed the title
|
Dependent PR was changed to ManageIQ/manageiq#19238, which is merged. |
tinaafitz
approved these changes
Sep 10, 2019
ghost
deleted the
simaishi
pushed a commit
that referenced
this pull request
Nov 4, 2019
…_for_inventory_refresh [V2V] Remove CheckVmInInventory state (cherry picked from commit 32ef3e1) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1768521
|
Ivanchuk backport details: |
simaishi
added a commit
that referenced
this pull request
Dec 3, 2019
…_waiting_for_inventory_refresh" This reverts commit 8546669. https://bugzilla.redhat.com/show_bug.cgi?id=1768521
|
The backport reverted |
simaishi
pushed a commit
that referenced
this pull request
Feb 21, 2020
…_for_inventory_refresh [V2V] Remove CheckVmInInventory state (cherry picked from commit 32ef3e1) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1768521
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The state machine is being ported to InfraConversionJob.
This PR is the counterpart of ManageIQ/manageiq#19230.
A side effect of removing the CheckVmInInventory method, is that the Transform state machine is not needed anymore. So, the PR removes it too.
RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1747338
Depends on ManageIQ/manageiq#19238
Built on #569