Fixed Settings hierarchy on Global region #20299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrudman
requested review from
carbonin,
Fryguy,
gtanzillo and
jrafanie
as code owners
jrafanie
reviewed
Jun 22, 2020
yrudman
force-pushed
the
global-region-settings-fix
branch
4 times, most recently
from
6b98690
to
e82b446
Compare
yrudman
changed the title
|
@miq-bot add-label ivanchuk/yes, jansa/yes? |
carbonin
reviewed
Jun 23, 2020
Fryguy
reviewed
Jun 25, 2020
Fryguy
reviewed
Jun 25, 2020
Fryguy
reviewed
Jun 25, 2020
yrudman
force-pushed
the
global-region-settings-fix
branch
from
f8dbc05
to
9c19aaf
Compare
Fryguy
reviewed
Jun 25, 2020
yrudman
force-pushed
the
global-region-settings-fix
branch
from
d5b9924
to
9d71f17
Compare
|
Checked commits yrudman/manageiq@86f34c3~...9d71f17 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
simaishi
pushed a commit
that referenced
this pull request
Jul 1, 2020
Fixed Settings hierarchy on Global region (cherry picked from commit 68b086e) https://bugzilla.redhat.com/show_bug.cgi?id=1836158
|
Ivanchuk backport details: |
simaishi
pushed a commit
that referenced
this pull request
Jul 1, 2020
Fixed Settings hierarchy on Global region (cherry picked from commit 68b086e)
|
Jansa backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE:
On global region settings hierarchy
MiqRegion->Zone->MiqServerwas always using local region (which is global region), even for remote seversFixes https://bugzilla.redhat.com/show_bug.cgi?id=1836158
@miq-bot add-label bug, core