New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Podified] Adopt new memory/cpu request/limit(threshold) values #20847
Merged
Fryguy
merged 1 commit into
ManageIQ:master
from
jrafanie:new_cpu_and_memory_request_and_threshold_limits
Nov 30, 2020
Merged
[Podified] Adopt new memory/cpu request/limit(threshold) values #20847
Fryguy
merged 1 commit into
ManageIQ:master
from
jrafanie:new_cpu_and_memory_request_and_threshold_limits
Nov 30, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* cpu request. 25% to 15%. Run on nodes with less vCPUs/reserve less cpu. * cpu threshold/limit. 50% to 100%. Decrease CPU throttling in pods. * memory request. 250 to 500 MB. More realistic for worker pods. 250 MB wasn't used previously anyway, see below. * memory threshold/limit. 400 MB to 600 MB. This is more realistic and is a more common baseline allowing overrides to be removed. Note, prior to ManageIQ#20834, no request value was honored so kubenetes would use the limit as the request, causing us to reserve too much memory and cpu. Note 2, appliances only enforce memory threshold/limit so this change has minimal impact outside of podified.
Checked commit jrafanie@4a33201 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint |
Thanks to @thadjennings for doing the testing to make these recommendations. 🙇 |
Fryguy
approved these changes
Nov 30, 2020
Fryguy
added a commit
that referenced
this pull request
Nov 30, 2020
…d_threshold_limits Adopt new memory/cpu request/limit(threshold) values (cherry picked from commit 10d5e3a)
kasparov backport details:
|
simaishi
pushed a commit
that referenced
this pull request
Dec 3, 2020
…d_threshold_limits Adopt new memory/cpu request/limit(threshold) values (cherry picked from commit 10d5e3a)
Jansa backport details:
|
jrafanie
changed the title
Adopt new memory/cpu request/limit(threshold) values
[Podified] Adopt new memory/cpu request/limit(threshold) values
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note, prior to #20834, no request value was honored so kubenetes would use the limit as the request, causing us to reserve too much memory and cpu.
Note 2, appliances only enforce memory threshold/limit so this change has minimal impact outside of podified.