Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Podified] Adopt new memory/cpu request/limit(threshold) values #20847

Conversation

jrafanie
Copy link
Member

  • cpu request. 25% to 15%. Run on nodes with less vCPUs/reserve less cpu.
  • cpu threshold/limit. 50% to 100%. Decrease CPU throttling in pods.
  • memory request. 250 to 500 MB. More realistic for worker pods. 250 MB wasn't used previously anyway, see below.
  • memory threshold/limit. 400 MB to 600 MB. This is more realistic and is a more common baseline allowing overrides to be removed.

Note, prior to #20834, no request value was honored so kubenetes would use the limit as the request, causing us to reserve too much memory and cpu.

Note 2, appliances only enforce memory threshold/limit so this change has minimal impact outside of podified.

* cpu request. 25% to 15%. Run on nodes with less vCPUs/reserve less cpu.
* cpu threshold/limit. 50% to 100%. Decrease CPU throttling in pods.
* memory request. 250 to 500 MB.  More realistic for worker pods. 250 MB wasn't used previously anyway, see below.
* memory threshold/limit. 400 MB to 600 MB.  This is more realistic and is a more common baseline allowing overrides to be removed.

Note, prior to ManageIQ#20834, no request value was honored so kubenetes would use the limit as the request, causing us to reserve too much memory and cpu.

Note 2, appliances only enforce memory threshold/limit so this change has minimal impact outside of podified.
@miq-bot
Copy link
Member

miq-bot commented Nov 30, 2020

Checked commit jrafanie@4a33201 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@jrafanie
Copy link
Member Author

Thanks to @thadjennings for doing the testing to make these recommendations. 🙇

@Fryguy Fryguy merged commit 10d5e3a into ManageIQ:master Nov 30, 2020
@Fryguy Fryguy self-assigned this Nov 30, 2020
Fryguy added a commit that referenced this pull request Nov 30, 2020
…d_threshold_limits

Adopt new memory/cpu request/limit(threshold) values

(cherry picked from commit 10d5e3a)
@Fryguy
Copy link
Member

Fryguy commented Nov 30, 2020

kasparov backport details:

commit 5be051f43d6dd1869caacd2c2015dec0643a6161 (HEAD -> kasparov, upstream/kasparov)
Author: Jason Frey <fryguy9@gmail.com>
Date:   Mon Nov 30 16:49:07 2020 -0500

    Merge pull request #20847 from jrafanie/new_cpu_and_memory_request_and_threshold_limits

    Adopt new memory/cpu request/limit(threshold) values

    (cherry picked from commit 10d5e3a6666753751f16e4b3418d1c02e8abc358)

@jrafanie jrafanie deleted the new_cpu_and_memory_request_and_threshold_limits branch November 30, 2020 22:22
simaishi pushed a commit that referenced this pull request Dec 3, 2020
…d_threshold_limits

Adopt new memory/cpu request/limit(threshold) values

(cherry picked from commit 10d5e3a)
@simaishi
Copy link
Contributor

simaishi commented Dec 3, 2020

Jansa backport details:

$ git log -1
commit 11fdf27363956d904c071ceb5e6e9479e1c962ea
Author: Jason Frey <fryguy9@gmail.com>
Date:   Mon Nov 30 16:49:07 2020 -0500

    Merge pull request #20847 from jrafanie/new_cpu_and_memory_request_and_threshold_limits

    Adopt new memory/cpu request/limit(threshold) values

    (cherry picked from commit 10d5e3a6666753751f16e4b3418d1c02e8abc358)

@jrafanie jrafanie added this to Lasker in Roadmap Dec 8, 2020
@jrafanie jrafanie changed the title Adopt new memory/cpu request/limit(threshold) values [Podified] Adopt new memory/cpu request/limit(threshold) values Dec 8, 2020
@Fryguy Fryguy added this to the Lasker milestone Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Roadmap
  
Lasker
Development

Successfully merging this pull request may close these issues.

None yet

5 participants