Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 2.7 support/drop 2.5 #21095

Merged
merged 1 commit into from Mar 18, 2021
Merged

Add 2.7 support/drop 2.5 #21095

merged 1 commit into from Mar 18, 2021

Conversation

jrafanie
Copy link
Member

@jrafanie jrafanie commented Mar 3, 2021 •
edited

Part of #19678

To be backported to lasker and then further locked down to test only on ruby 2.6 on lasker.

@jrafanie jrafanie changed the title Add 2.7 support/drop 2.5 [WIP] Add 2.7 support/drop 2.5 Mar 3, 2021
@miq-bot miq-bot added the wip label Mar 3, 2021
@jrafanie jrafanie mentioned this pull request Mar 3, 2021
Closed
18 tasks
@miq-bot
Copy link
Member

miq-bot commented Mar 3, 2021

Checked commit jrafanie@dae63fc with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@jrafanie jrafanie changed the title [WIP] Add 2.7 support/drop 2.5 Add 2.7 support/drop 2.5 Mar 3, 2021
@miq-bot miq-bot removed the wip label Mar 3, 2021
@Fryguy Fryguy self-assigned this Mar 4, 2021
Fryguy
Fryguy approved these changes Mar 4, 2021
View reviewed changes
Copy link
Member

@Fryguy Fryguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM...I'll give it til next week before merge, just in case people don't see the article until then

@Fryguy Fryguy merged commit a53119f into ManageIQ:master Mar 18, 2021
@Fryguy
Copy link
Member

Fryguy commented Mar 18, 2021

Backported to lasker in commit 363f4d5.

commit 363f4d58624b545eed25c41819a2790f979f7652
Author: Jason Frey <fryguy9@gmail.com>
Date:   Thu Mar 18 17:27:43 2021 -0400

    Merge pull request #21095 from jrafanie/test_ruby_2_7_drop_2_5_support_master
    
    Add 2.7 support/drop 2.5
    
    (cherry picked from commit a53119fa6d550536eae6e2a5438c2cb97c58dac7)

Fryguy added a commit that referenced this pull request Mar 18, 2021
@Fryguy
Merge pull request #21095 from jrafanie/test_ruby_2_7_drop_2_5_suppor…
363f4d5 
…t_master

Add 2.7 support/drop 2.5

(cherry picked from commit a53119f)
@agrare agrare mentioned this pull request Mar 19, 2021
Merged
@agrare
Copy link
Member

agrare commented Mar 19, 2021 •
edited

We'll need to update cross-repo-test's .travis.yml: ManageIQ/manageiq-cross_repo-tests#345

@jrafanie
Copy link
Member Author

We'll need to update cross-repo-test's .travis.yml: ManageIQ/manageiq-cross_repo-tests#345

added to the checklist so we know what all needs to be done next time

@jrafanie jrafanie deleted the test_ruby_2_7_drop_2_5_support_master branch March 19, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fryguy Fryguy Fryguy approved these changes

@gtanzillo gtanzillo Awaiting requested review from gtanzillo

Assignees

@Fryguy Fryguy

Labels
dependencies lasker/backported ruby2.7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jrafanie @miq-bot @Fryguy @agrare