Move MiqExpression#parse to Target #22451
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Fryguy LMK if this is too big. It does have 2 commits to separate the moving parts. |
Don't think we even Target.new, but want a base implementation in there so we can use `&.column_type` over `try(:column_type)` Target is an undetermined entity. We default to non-numeric/:string. So even thought we could lookup the attribute type off of the target, hard-coding to a string was more in line with the existing code. will leverage column_type/numeric? in the next commit that converts parse_field_or_tag => parse commit They all change the same lines
Moving this over to MiqExpression so it can be used by other classes previous commit already ensured column_type and numeric are part of the interface leaving miq_expression's references to parse_field_or_tag alone because those will be deleted once preprocess_exp! stores a tag reference - This is an obvious play towards converting the triple serialized parse statements into a single And part of a play to drop get_col_info and only use Target.parse
kbrock
force-pushed
the
miq_expression_parse
branch
from
f8e67b4
to
df0f147
Compare
|
Checked commits kbrock/manageiq@1532a01~...df0f147 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint spec/lib/miq_expression/target_spec.rb
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #22397
move
MiqExpression.parse_field_or_tag=>MiqExpression::Target#parseMiqExpression.parse_field_or_tagcalls across in a followup. This PR got too big.(weekend fun)