Update GitWorktree/Rugged remote URL before pull if it has changed

[agrare]

If the URL of a GitRepository is changed after the sparse repo is cloned then we have to update the local remote url before fetch+merge in order to pull from the correct url.

Fixes #22970

[Fryguy]

I'm concerned about timing/usage/locking conflicts here. On delete we know that nobody is using the directory (well maybe 😅). However if something is running and ensures the git repository, then something else deletes it, then the original usage code continues on it will hit an empty directory.

[Fryguy]

I do see that it's WIP, but curious on your thoughts about that

[Fryguy]

I was originally thinking we'd just broadcast an "update remote" command. I can't imagine it's hard to change the remote.

[agrare]

On delete we know that nobody is using the directory (well maybe 😅).

Yeah...actually I don't think we know this on delete either 😆 so I agree we need locking around this. And yes that is why this is WIP (plus pending adding specs).

On a multi-worker and more-so multi-appliance environment I don't think that deleting the record means that no one else is currently using the directory. We've seen issues like this with ExtManagementSystem#destroy when another worker is refreshing the provider.

[agrare]

I was originally thinking we'd just broadcast an "update remote" command. I can't imagine it's hard to change the remote.

Yeah that's true I'll try that while holding the lock

[agrare]

I ran into some issues with ordering of callbacks and what is being run by the queue first (ConfigurationScriptSource runs a sync on update, then the queued update was run).

We already have an expectation that GitRepository#update_repo is run in order to get up to date refs so I added a check to change the remote url in update_repo before pull and I think it came out a lot cleaner

[agrare]

Okay with this change I'm able to create a ConfigurationScriptSource pointing to git@github.com:ManageIQ/workflows-examples branch master, then update it to point to git@github.com:agrare/workflows-examples branch test and immediately see 4 workflows instead of 3

[miq-bot]

Checked commits agrare/manageiq@c0739ae~...44d5c55 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
3 files checked, 0 offenses detected
Everything looks fine. 🏆