Add a deliver! version of GenericMailer.deliver
#23037
Conversation
agrare
changed the title
deliver! version of GenericMailer.deliverdeliver! version of GenericMailer.deliver
Add a version of `GenericMailer.deliver` which raises exceptions on failure.
agrare
force-pushed
the
add_generic_mailer_deliver!
branch
from
f9a6037
to
7c77e60
Compare
|
Checked commits agrare/manageiq@9beea07~...7c77e60 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
agrare
changed the title
deliver! version of GenericMailer.deliverdeliver! version of GenericMailer.deliver
|
@miq-bot cross-repo-test manageiq-ui-classic, manageiq-api, manageiq-content, manageiq-automation_engine |
From Pull Request: ManageIQ/manageiq#23037
From Pull Request: ManageIQ/manageiq#23037
| # catch delivery errors if raised, | ||
| rescue Net::SMTPError => e | ||
| msg.deliver_now! | ||
| rescue Net::SMTPError => e # catch delivery errors if raised |
There was a problem hiding this comment.
I thought rubocop prefers comments above the line
| rescue => e # catch delivery errors if raised, | ||
| _log.error("method: #{method} options: #{options} delivery-error #{e}") | ||
| end | ||
|
|
||
| def self.deliver_queue(method, options = {}, queue_options = {}) |
There was a problem hiding this comment.
I'm assuming this is ok but it is kind of deliver_queue!
|
@Fryguy Is this good to go? |
|
cross-repo failed on the automation engine - not sure if related or not |
|
@miq-bot cross-repo-test manageiq-ui-classic, manageiq-api, manageiq-content, ManageIQ/manageiq-automation_engine#548 |
From Pull Request: ManageIQ/manageiq#23037
|
ManageIQ/manageiq-automation_engine#548 fixes the automation_engine failure |
|
Cross repo is green now |
|
Backported to |
Add a `deliver!` version of `GenericMailer.deliver` (cherry picked from commit 671a04b)
Add a version of
GenericMailer.deliverwhich raises exceptions on failure and have the "async" queue/task methods call this. This should allow for us to get an error on the miq_task if delivery failed.