Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provision workflow #23039

Merged
merged 4 commits into from
May 23, 2024
Merged

Provision workflow #23039

merged 4 commits into from
May 23, 2024

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented May 21, 2024

first commit is squashed:

This adds a change that provisions send all options to dialog.
This is required for asl to properly modify requests

Fixes #23034
(or rather replaces it but... yea)

@kbrock kbrock requested review from agrare and Fryguy as code owners May 21, 2024 00:05
@Fryguy Fryguy changed the title Provision workflow [WIP] Provision workflow May 21, 2024
@miq-bot miq-bot added the wip label May 21, 2024
@kbrock
Copy link
Member Author

kbrock commented May 21, 2024

update:

  • handle nil parent_task_id
  • send all option values to floe

update:

  • make tests pass

app/models/miq_provision.rb Outdated Show resolved Hide resolved
@kbrock kbrock changed the title [WIP] Provision workflow Provision workflow May 23, 2024
@kbrock
Copy link
Member Author

kbrock commented May 23, 2024

Update:

  • introduce workflow_inputs (similar to dialog_values)
  • remove old comment in spec

@miq-bot miq-bot removed the wip label May 23, 2024
@miq-bot
Copy link
Member

miq-bot commented May 23, 2024

Checked commits kbrock/manageiq@d9a492e~...1931ee1 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
5 files checked, 0 offenses detected
Everything looks fine. 👍

@Fryguy Fryguy merged commit ace696f into ManageIQ:master May 23, 2024
8 checks passed
@Fryguy
Copy link
Member

Fryguy commented May 23, 2024

Backported to radjabov in commit 8d5cd76.

commit 8d5cd76a5e44331c991ab54d02ef0fb59fcb0d52
Author: Jason Frey <fryguy9@gmail.com>
Date:   Thu May 23 14:01:12 2024 -0400

    Merge pull request #23039 from kbrock/provision_workflow
    
    Provision workflow
    
    (cherry picked from commit ace696fa425aca676e9a281ded685486815cdc7d)

Fryguy added a commit that referenced this pull request May 23, 2024
Provision workflow

(cherry picked from commit ace696f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants