Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RADJABOV] Update Gemfile.lock.release after merge of master into radjabov #23046

Merged
merged 1 commit into from
May 23, 2024

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented May 22, 2024

@bdunne @jrafanie @agrare Please review.

@Fryguy
Copy link
Member Author

Fryguy commented May 22, 2024

I eyeballed everything and it looked good to me, but I want all eyes on it to be sure nothing is unexpected.

@Fryguy
Copy link
Member Author

Fryguy commented May 22, 2024

Actually I just realized I built this with Ruby 3.1.4 and maybe I should try with Ruby 3.1.5, because of some of the default gems in the list (like csv and big_decimal)

@miq-bot
Copy link
Member

miq-bot commented May 22, 2024

Checked commit Fryguy@ed645c5 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@Fryguy
Copy link
Member Author

Fryguy commented May 22, 2024

Ok I rebuilt locally with 3.1.5 and the content is the same as this PR.

@bdunne
Copy link
Member

bdunne commented May 22, 2024

Actually I just realized I built this with Ruby 3.1.4 and maybe I should try with Ruby 3.1.5, because of some of the default gems in the list (like csv and big_decimal)

We should be shipping with ruby 3.1.4-143

Copy link
Member

@bdunne bdunne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 LGTM

Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agrare agrare merged commit c8b623e into ManageIQ:radjabov May 23, 2024
3 checks passed
@Fryguy Fryguy deleted the update_lockfile branch May 23, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants