Extract toolbar management from ApplicationHelper

[matthewd]

We don't need to define all these globally-visible helper methods -- the usable surface is actually two very narrow methods. Their respective supporting methods don't even overlap.

This is a straightforward relocation -- other than adding some trivial plumbing, the code is all moving untouched.

It's a bit ugly where we have to pass through all the instance variables -- but I suspect that ugliness is a Feature: so much state! 😢

This is only moving things around... but it takes application_helper.rb from 2937 lines to 1250, and application_helper_spec.rb from 4259 to 1447.

[Fryguy]

Can you explain what this is for? I'm concerned it will affect other tests (I'm not sure the scoping of this method_missing)

[matthewd]

It's scoped to the containing describe block (which is actually a class, way under the covers).

It allows the below specs to continue working (and looking) just as they did before.

Specifically, it: 1) makes the methods accessible without needing an explicit receiver, and 2) bypasses the fact that they're now all private.

[Fryguy]

@dclarizio or @martinpovolny or @h-kataria Please review.

[martinpovolny]

There's a trello card https://trello.com/c/1RYJltFP/91-redesign-toolbars-and-toolbar-buttons that I happen to own and there's link to a branch that suggest that I plan a more complex redesign in this area. So while I welcome any help with cleaning up the UI code I would prefer if we do not work one over another on the same thing. There's a bunch of other stuff that noone is working on and we have no cards for it -- such as the expression editor.

Even though this might be a simple relocation I will still have more work figuring out if I did not skip any piece or code as I carry on with the work on the toolbars separation and redesign :-(

[matthewd]

plan a more complex redesign

We seem to have plans for complex redesigns of a great many things. Right now I'm just shooting for "less awful, now", ahead of "much better, later".

Even though this might be a simple relocation I will still have more work figuring out if I did not skip any piece or code as I carry on

I'm not sure I understand this concern. But I'll be happy to take care of rebasing your change for you.

[Fryguy]

@martinpovolny I really like this PR and would love to merge it, even though there might be a conflict with your full blown changes. In particular, it really makes it very clear what the couplings are [1] [2], and removes a TON of methods from the global ApplicationHelper which are very toolbar specific.

Given @matthewd's offer to rebase your branch, are you ok with this being merged?

[martinpovolny]

@Fryguy : I am no against merging this. I just suggest that next time, it would be good to check the trello for work going on in the particular area that e.g. @matthewd is about to cleanup.

My work is in pretty early stage so thx for the rebase offer, but I will have to handle it somehow.

[dclarizio]

@matthewd @Fryguy

Either I or @h-kataria will try to give this branch a quick test. As @martinpovolny states, if someone (not just @matthewd) is to embark on some refactoring/cleanup, it might be worthwhile to check the UI Trello board for ongoing or planned work in the area. Can also ping me quickly anytime to see if there is any overlap. Thx, Dan

[miq-bot]

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

[miq-bot]

Checked commit matthewd@17c98a3 with rubocop 0.32.0
6 files checked, 975 offenses detected

app/helpers/application_helper.rb

• 🔹 - Line 269, Col 3 - Metrics/MethodLength - Method has too many lines. [36/25]

app/helpers/application_helper/toolbar_builder.rb

• 🔴 Warn - Line 55, Col 7 - Lint/UselessAssignment - Useless assignment to variable - sep_node.
• 🔴 Warn - Line 114, Col 24 - Lint/Eval - The use of eval is a serious security risk.
• 🔴 Warn - Line 121, Col 23 - Lint/Eval - The use of eval is a serious security risk.
• 🔴 Warn - Line 153, Col 51 - Lint/AssignmentInCondition - Assignment in condition - you probably meant to use ==.
• 🔴 Warn - Line 157, Col 19 - Lint/Eval - The use of eval is a serious security risk.
• 🔴 Warn - Line 183, Col 19 - Lint/Eval - The use of eval is a serious security risk.
• 🔴 Warn - Line 1286, Col 13 - Lint/Eval - The use of eval is a serious security risk.
• 🔴 Warn - Line 1288, Col 11 - Lint/Eval - The use of eval is a serious security risk.
• 🔴 Warn - Line 1319, Col 13 - Lint/Eval - The use of eval is a serious security risk.
• 🔴 Warn - Line 1322, Col 21 - Lint/Eval - The use of eval is a serious security risk.
• 🔶 - Line 1, Col 7 - Style/ClassAndModuleChildren - Use nested module/class definitions instead of compact style.
• 🔶 - Line 32, Col 92 - Style/ColonMethodCall - Do not use :: for method calls.
• 🔶 - Line 34, Col 5 - Style/LeadingCommentSpace - Missing space after #.
• 🔶 - Line 43, Col 18 - Style/EmptyLiteral - Use hash literal {} instead of Hash.new.
• 🔶 - Line 46, Col 20 - Style/EmptyLiteral - Use array literal [] instead of Array.new.
• 🔶 - Line 48, Col 5 - Style/CommentIndentation - Incorrect indentation detected (column 4 instead of 6).
• 🔶 - Line 48, Col 5 - Style/LeadingCommentSpace - Missing space after #.
• 🔶 - Line 49, Col 7 - Style/LeadingCommentSpace - Missing space after #.
• 🔶 - Line 51, Col 7 - Style/CommentIndentation - Incorrect indentation detected (column 6 instead of 4).
• 🔶 - Line 51, Col 7 - Style/LeadingCommentSpace - Missing space after #.
• 🔶 - Line 52, Col 5 - Style/LeadingCommentSpace - Missing space after #.
• 🔶 - Line 60, Col 9 - Style/MultilineOperationIndentation - Align the operands of a condition in an if statement spanning multiple lines.
• 🔶 - Line 60, Col 10 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 60, Col 27 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 60, Col 42 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 60, Col 61 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 61, Col 27 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 68, Col 16 - Style/DeprecatedHashMethods - Hash#has_key? is deprecated in favor of Hash#key?.
• 🔶 - Line 70, Col 20 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 70, Col 24 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 71, Col 31 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 71, Col 37 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 72, Col 31 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 72, Col 36 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 73, Col 31 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 73, Col 39 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 84, Col 13 - Style/MultilineOperationIndentation - Align the operands of a condition in an if statement spanning multiple lines.
• 🔶 - Line 93, Col 1 - Style/CommentIndentation - Incorrect indentation detected (column 0 instead of 14).
• 🔶 - Line 99, Col 20 - Style/DeprecatedHashMethods - Hash#has_key? is deprecated in favor of Hash#key?.
• 🔶 - Line 100, Col 28 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 100, Col 64 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 105, Col 24 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 105, Col 28 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 106, Col 35 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 106, Col 41 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 107, Col 35 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 107, Col 40 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 108, Col 35 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 108, Col 43 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 122, Col 42 - Style/ClassCheck - Prefer Object#kind_of? over Object#is_a?.
• 🔶 - Line 128, Col 11 - Style/UnlessElse - Do not use unless with else. Rewrite these with the positive case first.
• 🔶 - Line 131, Col 1 - Style/CommentIndentation - Incorrect indentation detected (column 0 instead of 12).
• 🔶 - Line 136, Col 19 - Style/DeprecatedHashMethods - Hash#has_key? is deprecated in favor of Hash#key?.
• 🔶 - Line 141, Col 25 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 141, Col 40 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 142, Col 25 - Style/AlignArray - Align the elements of an array literal if they span more than one line.
• 🔶 - Line 142, Col 42 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 143, Col 25 - Style/AlignArray - Align the elements of an array literal if they span more than one line.
• 🔶 - Line 143, Col 39 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 143, Col 54 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 144, Col 25 - Style/AlignArray - Align the elements of an array literal if they span more than one line.
• 🔶 - Line 144, Col 36 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 144, Col 48 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 144, Col 60 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 148, Col 20 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 148, Col 24 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 149, Col 31 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 149, Col 37 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 150, Col 31 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 150, Col 36 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 150, Col 62 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 150, Col 100 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 151, Col 31 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 151, Col 39 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 155, Col 11 - Style/LeadingCommentSpace - Missing space after #.
• 🔶 - Line 157, Col 11 - Style/NegatedIf - Favor unless over if for negative conditions.
• 🔶 - Line 158, Col 38 - Style/ClassCheck - Prefer Object#kind_of? over Object#is_a?.
• 🔶 - Line 169, Col 40 - Style/BracesAroundHashParameters - Redundant curly braces around a hash parameter.
• 🔶 - Line 169, Col 45 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 169, Col 70 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 177, Col 19 - Style/DeprecatedHashMethods - Hash#has_key? is deprecated in favor of Hash#key?.
• 🔶 - Line 179, Col 20 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 179, Col 24 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 180, Col 31 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 180, Col 37 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 181, Col 31 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 181, Col 36 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 182, Col 31 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 182, Col 39 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 190, Col 40 - Style/BracesAroundHashParameters - Redundant curly braces around a hash parameter.
• 🔶 - Line 190, Col 45 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 190, Col 70 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 206, Col 48 - Style/DeprecatedHashMethods - Hash#has_key? is deprecated in favor of Hash#key?.
• 🔶 - Line 207, Col 26 - Style/EmptyLiteral - Use hash literal {} instead of Hash.new.
• 🔶 - Line 221, Col 11 - Style/EmptyLiteral - Use hash literal {} instead of Hash.new.
• 🔶 - Line 227, Col 38 - Style/DeprecatedHashMethods - Hash#has_key? is deprecated in favor of Hash#key?.
• 🔶 - Line 234, Col 15 - Style/EmptyLiteral - Use hash literal {} instead of Hash.new.
• 🔶 - Line 242, Col 8 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 242, Col 69 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 247, Col 21 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 247, Col 67 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 252, Col 14 - Style/IndentHash - Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
• 🔶 - Line 254, Col 12 - Style/IndentHash - Indent the right brace the same as the start of the line where the left brace is.
• 🔶 - Line 263, Col 17 - Style/WhenThen - Do not use when x;. Use when x then instead.
• 🔶 - Line 264, Col 22 - Style/WhenThen - Do not use when x;. Use when x then instead.
• 🔶 - Line 271, Col 17 - Style/WhenThen - Do not use when x;. Use when x then instead.
• 🔶 - Line 272, Col 25 - Style/WhenThen - Do not use when x;. Use when x then instead.
• 🔶 - Line 273, Col 5 - Style/EmptyElse - Redundant else-clause.
• 🔶 - Line 286, Col 15 - Style/EmptyLiteral - Use hash literal {} instead of Hash.new.
• 🔶 - Line 291, Col 43 - Style/DeprecatedHashMethods - Hash#has_key? is deprecated in favor of Hash#key?.
• 🔶 - Line 300, Col 31 - Style/AndOr - Use && instead of and.
• 🔶 - Line 327, Col 7 - Style/CaseIndentation - Indent when as deep as case.
• 🔶 - Line 328, Col 32 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 328, Col 59 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 328, Col 85 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 329, Col 13 - Style/AlignArray - Align the elements of an array literal if they span more than one line.
• 🔶 - Line 332, Col 7 - Style/CaseIndentation - Indent when as deep as case.
• 🔶 - Line 333, Col 32 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 333, Col 57 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 333, Col 81 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 334, Col 13 - Style/AlignArray - Align the elements of an array literal if they span more than one line.
• 🔶 - Line 338, Col 5 - Style/RedundantReturn - Redundant return detected.
• 🔶 - Line 343, Col 7 - Style/CaseIndentation - Indent when as deep as case.
• 🔶 - Line 345, Col 7 - Style/CaseIndentation - Indent when as deep as case.
• 🔶 - Line 347, Col 11 - Style/CaseIndentation - Indent when as deep as case.
• 🔶 - Line 348, Col 20 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 348, Col 38 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 349, Col 11 - Style/CaseIndentation - Indent when as deep as case.
• 🔶 - Line 350, Col 20 - Style/MultilineTernaryOperator - Avoid multi-line ?: (the ternary operator); use if/unless instead.
• 🔶 - Line 353, Col 11 - Style/CaseIndentation - Indent when as deep as case.
• 🔶 - Line 354, Col 20 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 354, Col 32 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 355, Col 11 - Style/CaseIndentation - Indent when as deep as case.
• 🔶 - Line 356, Col 20 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 356, Col 43 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 357, Col 11 - Style/CaseIndentation - Indent when as deep as case.
• 🔶 - Line 357, Col 43 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 369, Col 11 - Style/CaseIndentation - Indent when as deep as case.
• 🔶 - Line 370, Col 20 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 370, Col 45 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 371, Col 11 - Style/CaseIndentation - Indent when as deep as case.
• 🔶 - Line 372, Col 20 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 372, Col 38 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 376, Col 7 - Style/CaseIndentation - Indent when as deep as case.
• 🔶 - Line 378, Col 7 - Style/CaseIndentation - Indent when as deep as case.
• 🔶 - Line 379, Col 16 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 379, Col 33 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 379, Col 46 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 379, Col 59 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 407, Col 9 - Style/MultilineOperationIndentation - Align the operands of a condition in an if statement spanning multiple lines.
• 🔶 - Line 411, Col 7 - Style/CaseIndentation - Indent when as deep as case.
• 🔶 - Line 413, Col 11 - Style/CaseIndentation - Indent when as deep as case.
• 🔶 - Line 415, Col 11 - Style/CaseIndentation - Indent when as deep as case.
• 🔶 - Line 419, Col 7 - Style/CaseIndentation - Indent when as deep as case.
• 🔶 - Line 424, Col 18 - Style/MultilineTernaryOperator - Avoid multi-line ?: (the ternary operator); use if/unless instead.
• 🔶 - Line 429, Col 18 - Style/MultilineTernaryOperator - Avoid multi-line ?: (the ternary operator); use if/unless instead.
• 🔶 - Line 430, Col 18 - Style/MultilineOperationIndentation - Use 2 (not 7) spaces for indenting an expression spanning multiple lines.
• 🔶 - Line 432, Col 7 - Style/CaseIndentation - Indent when as deep as case.
• 🔶 - Line 434, Col 11 - Style/CaseIndentation - Indent when as deep as case.
• 🔶 - Line 436, Col 11 - Style/CaseIndentation - Indent when as deep as case.
• 🔶 - Line 436, Col 28 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 436, Col 42 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 437, Col 20 - Style/MultilineTernaryOperator - Avoid multi-line ?: (the ternary operator); use if/unless instead.
• 🔶 - Line 438, Col 17 - Style/MultilineOperationIndentation - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
• 🔶 - Line 476, Col 20 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 485, Col 56 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 485, Col 68 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 485, Col 80 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 487, Col 5 - Style/LeadingCommentSpace - Missing space after #.
• 🔶 - Line 495, Col 5 - Style/LeadingCommentSpace - Missing space after #.
• 🔶 - Line 497, Col 29 - Style/MultilineOperationIndentation - Align the operands of a condition in an if statement spanning multiple lines.
• 🔶 - Line 500, Col 14 - Style/MultilineTernaryOperator - Avoid multi-line ?: (the ternary operator); use if/unless instead.
• 🔶 - Line 500, Col 24 - Style/SpaceAroundOperators - Operator && should be surrounded with a single space.
• 🔶 - Line 501, Col 14 - Style/MultilineOperationIndentation - Use 2 (not 7) spaces for indenting an expression spanning multiple lines.
• 🔶 - Line 501, Col 24 - Style/SpaceAroundOperators - Operator && should be surrounded with a single space.
• 🔶 - Line 502, Col 54 - Style/SpaceAroundOperators - Operator && should be surrounded with a single space.
• 🔶 - Line 503, Col 16 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 503, Col 26 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 504, Col 43 - Style/SpaceAroundOperators - Operator ? should be surrounded with a single space.
• 🔶 - Line 519, Col 5 - Style/LeadingCommentSpace - Missing space after #.
• 🔶 - Line 520, Col 104 - Style/SpaceAroundOperators - Operator && should be surrounded with a single space.
• 🔶 - Line 526, Col 21 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 526, Col 35 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 531, Col 5 - Style/LeadingCommentSpace - Missing space after #.
• 🔶 - Line 538, Col 7 - Style/MultilineOperationIndentation - Align the operands of a condition in an if statement spanning multiple lines.
• 🔶 - Line 540, Col 5 - Style/IfUnlessModifier - Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
• 🔶 - Line 564, Col 41 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 565, Col 23 - Style/MultilineOperationIndentation - Align the operands of a condition in an if statement spanning multiple lines.
• 🔶 - Line 569, Col 5 - Style/LeadingCommentSpace - Missing space after #.
• 🔶 - Line 570, Col 41 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 570, Col 70 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 570, Col 92 - Style/SpaceAfterComma - Space missing after comma.

[miq-bot]

...continued

• 🔶 - Line 574, Col 43 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 574, Col 53 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 574, Col 75 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 575, Col 11 - Style/MultilineOperationIndentation - Align the operands of a condition in an if statement spanning multiple lines.
• 🔶 - Line 580, Col 7 - Style/NegatedIf - Favor unless over if for negative conditions.
• 🔶 - Line 590, Col 7 - Style/NegatedIf - Favor unless over if for negative conditions.
• 🔶 - Line 590, Col 23 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 623, Col 9 - Style/NegatedIf - Favor unless over if for negative conditions.
• 🔶 - Line 636, Col 9 - Style/NegatedIf - Favor unless over if for negative conditions.
• 🔶 - Line 638, Col 9 - Style/NegatedIf - Favor unless over if for negative conditions.
• 🔶 - Line 640, Col 9 - Style/NegatedIf - Favor unless over if for negative conditions.
• 🔶 - Line 645, Col 9 - Style/NegatedIf - Favor unless over if for negative conditions.
• 🔶 - Line 652, Col 9 - Style/NegatedIf - Favor unless over if for negative conditions.
• 🔶 - Line 652, Col 45 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 654, Col 9 - Style/NegatedIf - Favor unless over if for negative conditions.
• 🔶 - Line 654, Col 45 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 669, Col 9 - Style/NegatedIf - Favor unless over if for negative conditions.
• 🔶 - Line 671, Col 9 - Style/NegatedIf - Favor unless over if for negative conditions.
• 🔶 - Line 671, Col 45 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 673, Col 9 - Style/NegatedIf - Favor unless over if for negative conditions.
• 🔶 - Line 673, Col 45 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 678, Col 9 - Style/NegatedIf - Favor unless over if for negative conditions.
• 🔶 - Line 678, Col 45 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 680, Col 9 - Style/NegatedIf - Favor unless over if for negative conditions.
• 🔶 - Line 680, Col 45 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 690, Col 9 - Style/NegatedIf - Favor unless over if for negative conditions.
• 🔶 - Line 690, Col 45 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 692, Col 9 - Style/NegatedIf - Favor unless over if for negative conditions.
• 🔶 - Line 694, Col 45 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 695, Col 13 - Style/MultilineOperationIndentation - Align the operands of a condition in an if statement spanning multiple lines.
• 🔶 - Line 697, Col 45 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 698, Col 13 - Style/MultilineOperationIndentation - Align the operands of a condition in an if statement spanning multiple lines.
• 🔶 - Line 700, Col 45 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 701, Col 13 - Style/MultilineOperationIndentation - Align the operands of a condition in an if statement spanning multiple lines.
• 🔶 - Line 713, Col 11 - Style/MultilineOperationIndentation - Align the operands of a condition in an if statement spanning multiple lines.
• 🔶 - Line 713, Col 12 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 717, Col 24 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 720, Col 68 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 761, Col 9 - Style/NegatedIf - Favor unless over if for negative conditions.
• 🔶 - Line 763, Col 9 - Style/NegatedIf - Favor unless over if for negative conditions.
• 🔶 - Line 765, Col 9 - Style/NegatedIf - Favor unless over if for negative conditions.
• 🔶 - Line 767, Col 9 - Style/NegatedIf - Favor unless over if for negative conditions.
• 🔶 - Line 771, Col 9 - Style/NegatedIf - Favor unless over if for negative conditions.
• 🔶 - Line 773, Col 9 - Style/NegatedIf - Favor unless over if for negative conditions.
• 🔶 - Line 775, Col 9 - Style/NegatedIf - Favor unless over if for negative conditions.
• 🔶 - Line 777, Col 9 - Style/NegatedIf - Favor unless over if for negative conditions.
• 🔶 - Line 783, Col 9 - Style/NegatedIf - Favor unless over if for negative conditions.
• 🔶 - Line 796, Col 9 - Style/NegatedIf - Favor unless over if for negative conditions.
• 🔶 - Line 805, Col 9 - Style/NegatedIf - Favor unless over if for negative conditions.
• 🔶 - Line 807, Col 9 - Style/NegatedIf - Favor unless over if for negative conditions.
• 🔶 - Line 807, Col 45 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 809, Col 9 - Style/NegatedIf - Favor unless over if for negative conditions.
• 🔶 - Line 811, Col 9 - Style/NegatedIf - Favor unless over if for negative conditions.
• 🔶 - Line 811, Col 45 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 813, Col 24 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 815, Col 24 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 817, Col 24 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 819, Col 24 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 825, Col 24 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 827, Col 24 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 829, Col 24 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 839, Col 9 - Style/NegatedIf - Favor unless over if for negative conditions.
• 🔶 - Line 841, Col 9 - Style/NegatedIf - Favor unless over if for negative conditions.
• 🔶 - Line 843, Col 9 - Style/NegatedIf - Favor unless over if for negative conditions.
• 🔶 - Line 846, Col 5 - Style/RedundantReturn - Redundant return detected.
• 🔶 - Line 856, Col 20 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 856, Col 33 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 856, Col 47 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 858, Col 5 - Style/LeadingCommentSpace - Missing space after #.
• 🔶 - Line 860, Col 145 - Style/SpaceBeforeBlockBraces - Space missing to the left of {.
• 🔶 - Line 860, Col 145 - Style/SpaceInsideBlockBraces - Space between { and | missing.
• 🔶 - Line 860, Col 166 - Style/NonNilCheck - Prefer !expression.nil? over expression != nil.
• 🔶 - Line 860, Col 172 - Style/SpaceInsideBlockBraces - Space missing inside }.
• 🔶 - Line 908, Col 108 - Style/LeadingCommentSpace - Missing space after #.
• 🔶 - Line 961, Col 9 - Style/NegatedIf - Favor unless over if for negative conditions.
• 🔶 - Line 965, Col 9 - Style/NegatedIf - Favor unless over if for negative conditions.
• 🔶 - Line 967, Col 9 - Style/NegatedIf - Favor unless over if for negative conditions.
• 🔶 - Line 1021, Col 50 - Style/FormatString - Favor format over String#%.
• 🔶 - Line 1033, Col 74 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 1034, Col 82 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 1037, Col 9 - Style/NegatedIf - Favor unless over if for negative conditions.
• 🔶 - Line 1081, Col 94 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 1083, Col 40 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 1111, Col 11 - Style/MultilineOperationIndentation - Align the operands of a condition in an if statement spanning multiple lines.
• 🔶 - Line 1144, Col 9 - Style/NegatedIf - Favor unless over if for negative conditions.
• 🔶 - Line 1151, Col 11 - Style/UnlessElse - Do not use unless with else. Rewrite these with the positive case first.
• 🔶 - Line 1166, Col 36 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 1171, Col 9 - Style/NegatedIf - Favor unless over if for negative conditions.
• 🔶 - Line 1178, Col 89 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 1179, Col 69 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 1180, Col 90 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 1185, Col 13 - Style/MultilineOperationIndentation - Align the operands of a condition in a elsif statement spanning multiple lines.
• 🔶 - Line 1186, Col 13 - Style/MultilineOperationIndentation - Align the operands of a condition in a elsif statement spanning multiple lines.
• 🔶 - Line 1187, Col 13 - Style/MultilineOperationIndentation - Align the operands of a condition in a elsif statement spanning multiple lines.
• 🔶 - Line 1210, Col 7 - Style/LeadingCommentSpace - Missing space after #.
• 🔶 - Line 1225, Col 16 - Style/MultilineTernaryOperator - Avoid multi-line ?: (the ternary operator); use if/unless instead.
• 🔶 - Line 1226, Col 13 - Style/MultilineOperationIndentation - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
• 🔶 - Line 1251, Col 45 - Style/WhenThen - Do not use when x;. Use when x then instead.
• 🔶 - Line 1252, Col 32 - Style/WhenThen - Do not use when x;. Use when x then instead.
• 🔶 - Line 1271, Col 5 - Style/RedundantReturn - Redundant return detected.
• 🔶 - Line 1280, Col 19 - Style/DeprecatedHashMethods - Hash#has_key? is deprecated in favor of Hash#key?.
• 🔶 - Line 1280, Col 72 - Style/NestedTernaryOperator - Ternary operators must not be nested. Prefer if/else constructs instead.
• 🔶 - Line 1280, Col 77 - Style/DeprecatedHashMethods - Hash#has_key? is deprecated in favor of Hash#key?.
• 🔶 - Line 1282, Col 26 - Style/EmptyLiteral - Use hash literal {} instead of Hash.new.
• 🔶 - Line 1289, Col 8 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 1289, Col 20 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 1289, Col 32 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 1291, Col 17 - Style/RegexpLiteral - Use %r around regular expression.
• 🔶 - Line 1291, Col 40 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 1293, Col 30 - Style/SpaceAroundOperators - Surrounding space missing for operator -.
• 🔶 - Line 1314, Col 5 - Style/IndentArray - Indent the right bracket the same as the left bracket.
• 🔶 - Line 1332, Col 31 - Style/SpaceAroundBlockParameters - Space before first block parameter detected.
• 🔶 - Line 1332, Col 37 - Style/SpaceAroundBlockParameters - Space after last block parameter detected.
• 🔶 - Line 1347, Col 1 - Style/EmptyLinesAroundClassBody - Extra empty line detected at class body end.
• 🔹 - Line 1, Col 1 - Metrics/ClassLength - Class has too many lines. [1200/100]
• 🔹 - Line 29, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for build_toolbar_buttons_and_xml is too high. [258.8/15]
• 🔹 - Line 29, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for build_toolbar_buttons_and_xml is too high. [84/6]
• 🔹 - Line 29, Col 3 - Metrics/MethodLength - Method has too many lines. [141/25]
• 🔹 - Line 29, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for build_toolbar_buttons_and_xml is too high. [90/7]
• 🔹 - Line 32, Col 121 - Metrics/LineLength - Line is too long. [146/120]
• 🔹 - Line 64, Col 121 - Metrics/LineLength - Line is too long. [186/120]
• 🔹 - Line 93, Col 121 - Metrics/LineLength - Line is too long. [134/120]
• 🔹 - Line 110, Col 17 - Metrics/BlockNesting - Avoid more than 3 levels of block nesting.
• 🔹 - Line 114, Col 17 - Metrics/BlockNesting - Avoid more than 3 levels of block nesting.
• 🔹 - Line 115, Col 17 - Metrics/BlockNesting - Avoid more than 3 levels of block nesting.
• 🔹 - Line 150, Col 121 - Metrics/LineLength - Line is too long. [135/120]
• 🔹 - Line 205, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for create_custom_button_hash is too high. [22.29/15]
• 🔹 - Line 216, Col 121 - Metrics/LineLength - Line is too long. [128/120]
• 🔹 - Line 220, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for create_raw_custom_button_hash is too high. [20.05/15]
• 🔹 - Line 232, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for custom_buttons_hash is too high. [18.06/15]
• 🔹 - Line 283, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for get_custom_buttons is too high. [48.43/15]
• 🔹 - Line 293, Col 121 - Metrics/LineLength - Line is too long. [135/120]
• 🔹 - Line 294, Col 121 - Metrics/LineLength - Line is too long. [136/120]
• 🔹 - Line 325, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for build_toolbar_hide_button_cb is too high. [7/6]
• 🔹 - Line 341, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for build_toolbar_hide_button_ops is too high. [33.3/15]
• 🔹 - Line 341, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for build_toolbar_hide_button_ops is too high. [26/6]
• 🔹 - Line 341, Col 3 - Metrics/MethodLength - Method has too many lines. [41/25]
• 🔹 - Line 341, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for build_toolbar_hide_button_ops is too high. [17/7]
• 🔹 - Line 385, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for build_toolbar_hide_button_pxe is too high. [7/6]
• 🔹 - Line 385, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for build_toolbar_hide_button_pxe is too high. [8/7]
• 🔹 - Line 404, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for build_toolbar_hide_button_report is too high. [36.24/15]
• 🔹 - Line 404, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for build_toolbar_hide_button_report is too high. [29/6]
• 🔹 - Line 404, Col 3 - Metrics/MethodLength - Method has too many lines. [38/25]
• 🔹 - Line 404, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for build_toolbar_hide_button_report is too high. [23/7]
• 🔹 - Line 455, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for build_toolbar_hide_button is too high. [496.8/15]
• 🔹 - Line 455, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for build_toolbar_hide_button is too high. [322/6]
• 🔹 - Line 455, Col 3 - Metrics/MethodLength - Method has too many lines. [335/25]
• 🔹 - Line 455, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for build_toolbar_hide_button is too high. [254/7]
• 🔹 - Line 476, Col 121 - Metrics/LineLength - Line is too long. [207/120]
• 🔹 - Line 503, Col 121 - Metrics/LineLength - Line is too long. [121/120]
• 🔹 - Line 519, Col 121 - Metrics/LineLength - Line is too long. [145/120]
• 🔹 - Line 520, Col 121 - Metrics/LineLength - Line is too long. [138/120]
• 🔹 - Line 532, Col 121 - Metrics/LineLength - Line is too long. [144/120]
• 🔹 - Line 570, Col 121 - Metrics/LineLength - Line is too long. [124/120]
• 🔹 - Line 720, Col 121 - Metrics/LineLength - Line is too long. [122/120]
• 🔹 - Line 735, Col 121 - Metrics/LineLength - Line is too long. [132/120]
• 🔹 - Line 759, Col 121 - Metrics/LineLength - Line is too long. [130/120]
• 🔹 - Line 781, Col 121 - Metrics/LineLength - Line is too long. [137/120]
• 🔹 - Line 794, Col 121 - Metrics/LineLength - Line is too long. [137/120]
• 🔹 - Line 831, Col 121 - Metrics/LineLength - Line is too long. [126/120]
• 🔹 - Line 833, Col 121 - Metrics/LineLength - Line is too long. [126/120]
• 🔹 - Line 835, Col 121 - Metrics/LineLength - Line is too long. [126/120]
• 🔹 - Line 837, Col 121 - Metrics/LineLength - Line is too long. [126/120]
• 🔹 - Line 850, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for build_toolbar_disable_button is too high. [433.9/15]
• 🔹 - Line 850, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for build_toolbar_disable_button is too high. [279/6]
• 🔹 - Line 850, Col 3 - Metrics/MethodLength - Method has too many lines. [374/25]
• 🔹 - Line 850, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for build_toolbar_disable_button is too high. [217/7]
• 🔹 - Line 860, Col 121 - Metrics/LineLength - Line is too long. [183/120]
• 🔹 - Line 878, Col 11 - Metrics/BlockNesting - Avoid more than 3 levels of block nesting.
• 🔹 - Line 880, Col 121 - Metrics/LineLength - Line is too long. [164/120]
• 🔹 - Line 888, Col 11 - Metrics/BlockNesting - Avoid more than 3 levels of block nesting.
• 🔹 - Line 896, Col 11 - Metrics/BlockNesting - Avoid more than 3 levels of block nesting.
• 🔹 - Line 906, Col 121 - Metrics/LineLength - Line is too long. [123/120]
• 🔹 - Line 908, Col 121 - Metrics/LineLength - Line is too long. [180/120]
• 🔹 - Line 952, Col 121 - Metrics/LineLength - Line is too long. [135/120]
• 🔹 - Line 969, Col 121 - Metrics/LineLength - Line is too long. [132/120]
• 🔹 - Line 978, Col 121 - Metrics/LineLength - Line is too long. [132/120]
• 🔹 - Line 983, Col 121 - Metrics/LineLength - Line is too long. [142/120]
• 🔹 - Line 1021, Col 121 - Metrics/LineLength - Line is too long. [139/120]
• 🔹 - Line 1033, Col 121 - Metrics/LineLength - Line is too long. [133/120]
• 🔹 - Line 1034, Col 121 - Metrics/LineLength - Line is too long. [142/120]
• 🔹 - Line 1037, Col 121 - Metrics/LineLength - Line is too long. [152/120]
• 🔹 - Line 1081, Col 121 - Metrics/LineLength - Line is too long. [138/120]
• 🔹 - Line 1083, Col 121 - Metrics/LineLength - Line is too long. [159/120]
• 🔹 - Line 1106, Col 59 - Metrics/BlockNesting - Avoid more than 3 levels of block nesting.
• 🔹 - Line 1106, Col 121 - Metrics/LineLength - Line is too long. [184/120]
• 🔹 - Line 1108, Col 121 - Metrics/LineLength - Line is too long. [151/120]
• 🔹 - Line 1118, Col 11 - Metrics/BlockNesting - Avoid more than 3 levels of block nesting.
• 🔹 - Line 1123, Col 121 - Metrics/LineLength - Line is too long. [121/120]
• 🔹 - Line 1125, Col 121 - Metrics/LineLength - Line is too long. [125/120]
• 🔹 - Line 1129, Col 121 - Metrics/LineLength - Line is too long. [127/120]
• 🔹 - Line 1131, Col 121 - Metrics/LineLength - Line is too long. [129/120]
• 🔹 - Line 1133, Col 121 - Metrics/LineLength - Line is too long. [125/120]
• 🔹 - Line 1142, Col 19 - Metrics/BlockNesting - Avoid more than 3 levels of block nesting.

[miq-bot]

...continued

• 🔹 - Line 1142, Col 121 - Metrics/LineLength - Line is too long. [141/120]
• 🔹 - Line 1146, Col 121 - Metrics/LineLength - Line is too long. [130/120]
• 🔹 - Line 1149, Col 11 - Metrics/BlockNesting - Avoid more than 3 levels of block nesting.
• 🔹 - Line 1151, Col 11 - Metrics/BlockNesting - Avoid more than 3 levels of block nesting.
• 🔹 - Line 1160, Col 121 - Metrics/LineLength - Line is too long. [128/120]
• 🔹 - Line 1162, Col 121 - Metrics/LineLength - Line is too long. [124/120]
• 🔹 - Line 1167, Col 121 - Metrics/LineLength - Line is too long. [147/120]
• 🔹 - Line 1173, Col 121 - Metrics/LineLength - Line is too long. [136/120]
• 🔹 - Line 1178, Col 121 - Metrics/LineLength - Line is too long. [212/120]
• 🔹 - Line 1178, Col 157 - Metrics/BlockNesting - Avoid more than 3 levels of block nesting.
• 🔹 - Line 1179, Col 121 - Metrics/LineLength - Line is too long. [215/120]
• 🔹 - Line 1180, Col 121 - Metrics/LineLength - Line is too long. [163/120]
• 🔹 - Line 1199, Col 11 - Metrics/BlockNesting - Avoid more than 3 levels of block nesting.
• 🔹 - Line 1199, Col 121 - Metrics/LineLength - Line is too long. [150/120]
• 🔹 - Line 1204, Col 11 - Metrics/BlockNesting - Avoid more than 3 levels of block nesting.
• 🔹 - Line 1207, Col 121 - Metrics/LineLength - Line is too long. [128/120]
• 🔹 - Line 1212, Col 121 - Metrics/LineLength - Line is too long. [124/120]
• 🔹 - Line 1217, Col 121 - Metrics/LineLength - Line is too long. [143/120]
• 🔹 - Line 1226, Col 121 - Metrics/LineLength - Line is too long. [150/120]
• 🔹 - Line 1244, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for get_record_cls is too high. [16.52/15]
• 🔹 - Line 1260, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for build_toolbar_select_button is too high. [36.62/15]
• 🔹 - Line 1260, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for build_toolbar_select_button is too high. [22/6]
• 🔹 - Line 1260, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for build_toolbar_select_button is too high. [22/7]
• 🔹 - Line 1264, Col 121 - Metrics/LineLength - Line is too long. [121/120]
• 🔹 - Line 1275, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for build_toolbar_save_button is too high. [97.44/15]
• 🔹 - Line 1275, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for build_toolbar_save_button is too high. [27/6]
• 🔹 - Line 1275, Col 3 - Metrics/MethodLength - Method has too many lines. [45/25]
• 🔹 - Line 1275, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for build_toolbar_save_button is too high. [29/7]
• 🔹 - Line 1280, Col 121 - Metrics/LineLength - Line is too long. [138/120]
• 🔹 - Line 1290, Col 121 - Metrics/LineLength - Line is too long. [159/120]

app/helpers/application_helper/toolbar_chooser.rb

• 🔶 - Line 1, Col 7 - Style/ClassAndModuleChildren - Use nested module/class definitions instead of compact style.
• 🔶 - Line 33, Col 9 - Style/MultilineOperationIndentation - Align the operands of a condition in an if statement spanning multiple lines.
• 🔶 - Line 33, Col 10 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 33, Col 21 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 33, Col 34 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 33, Col 61 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 33, Col 85 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 42, Col 10 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 42, Col 21 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 42, Col 32 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 44, Col 11 - Style/IfUnlessModifier - Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
• 🔶 - Line 49, Col 43 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 49, Col 56 - Style/SpaceBeforeSemicolon - Space found before semicolon.
• 🔶 - Line 49, Col 57 - Style/WhenThen - Do not use when x;. Use when x then instead.
• 🔶 - Line 50, Col 63 - Style/SpaceBeforeSemicolon - Space found before semicolon.
• 🔶 - Line 50, Col 64 - Style/WhenThen - Do not use when x;. Use when x then instead.
• 🔶 - Line 51, Col 53 - Style/SpaceBeforeSemicolon - Space found before semicolon.
• 🔶 - Line 51, Col 54 - Style/WhenThen - Do not use when x;. Use when x then instead.
• 🔶 - Line 52, Col 46 - Style/SpaceBeforeSemicolon - Space found before semicolon.
• 🔶 - Line 52, Col 47 - Style/WhenThen - Do not use when x;. Use when x then instead.
• 🔶 - Line 53, Col 53 - Style/SpaceBeforeSemicolon - Space found before semicolon.
• 🔶 - Line 53, Col 54 - Style/WhenThen - Do not use when x;. Use when x then instead.
• 🔶 - Line 54, Col 50 - Style/SpaceBeforeSemicolon - Space found before semicolon.
• 🔶 - Line 54, Col 51 - Style/WhenThen - Do not use when x;. Use when x then instead.
• 🔶 - Line 87, Col 5 - Style/RedundantReturn - Redundant return detected.
• 🔶 - Line 92, Col 5 - Style/RedundantReturn - Redundant return detected.
• 🔶 - Line 132, Col 13 - Style/MultilineOperationIndentation - Align the operands of a condition in a elsif statement spanning multiple lines.
• 🔶 - Line 141, Col 5 - Style/RedundantReturn - Redundant return detected.
• 🔶 - Line 189, Col 10 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 189, Col 20 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 195, Col 5 - Style/RedundantReturn - Redundant return detected.
• 🔶 - Line 208, Col 5 - Style/RedundantReturn - Redundant return detected.
• 🔶 - Line 209, Col 7 - Style/CaseIndentation - Indent when as deep as case.
• 🔶 - Line 209, Col 18 - Style/Semicolon - Do not use semicolons to terminate expressions.
• 🔶 - Line 209, Col 18 - Style/WhenThen - Do not use when x;. Use when x then instead.
• 🔶 - Line 211, Col 11 - Style/CaseIndentation - Indent when as deep as case.
• 🔶 - Line 211, Col 36 - Style/WhenThen - Do not use when x;. Use when x then instead.
• 🔶 - Line 212, Col 11 - Style/CaseIndentation - Indent when as deep as case.
• 🔶 - Line 212, Col 28 - Style/WhenThen - Do not use when x;. Use when x then instead.
• 🔶 - Line 213, Col 11 - Style/CaseIndentation - Indent when as deep as case.
• 🔶 - Line 213, Col 27 - Style/WhenThen - Do not use when x;. Use when x then instead.
• 🔶 - Line 216, Col 7 - Style/CaseIndentation - Indent when as deep as case.
• 🔶 - Line 216, Col 16 - Style/WhenThen - Do not use when x;. Use when x then instead.
• 🔶 - Line 217, Col 7 - Style/CaseIndentation - Indent when as deep as case.
• 🔶 - Line 217, Col 15 - Style/WhenThen - Do not use when x;. Use when x then instead.
• 🔶 - Line 218, Col 7 - Style/CaseIndentation - Indent when as deep as case.
• 🔶 - Line 218, Col 16 - Style/WhenThen - Do not use when x;. Use when x then instead.
• 🔶 - Line 219, Col 7 - Style/CaseIndentation - Indent when as deep as case.
• 🔶 - Line 219, Col 16 - Style/WhenThen - Do not use when x;. Use when x then instead.
• 🔶 - Line 220, Col 7 - Style/CaseIndentation - Indent when as deep as case.
• 🔶 - Line 220, Col 15 - Style/WhenThen - Do not use when x;. Use when x then instead.
• 🔶 - Line 221, Col 7 - Style/CaseIndentation - Indent when as deep as case.
• 🔶 - Line 221, Col 16 - Style/WhenThen - Do not use when x;. Use when x then instead.
• 🔶 - Line 222, Col 7 - Style/CaseIndentation - Indent when as deep as case.
• 🔶 - Line 222, Col 16 - Style/WhenThen - Do not use when x;. Use when x then instead.
• 🔶 - Line 277, Col 5 - Style/RedundantReturn - Redundant return detected.
• 🔶 - Line 292, Col 15 - Style/MultilineTernaryOperator - Avoid multi-line ?: (the ternary operator); use if/unless instead.
• 🔶 - Line 297, Col 9 - Style/LeadingCommentSpace - Missing space after #.
• 🔶 - Line 300, Col 9 - Style/LeadingCommentSpace - Missing space after #.
• 🔶 - Line 303, Col 9 - Style/LeadingCommentSpace - Missing space after #.
• 🔶 - Line 307, Col 14 - Style/MultilineTernaryOperator - Avoid multi-line ?: (the ternary operator); use if/unless instead.
• 🔶 - Line 311, Col 14 - Style/MultilineTernaryOperator - Avoid multi-line ?: (the ternary operator); use if/unless instead.
• 🔶 - Line 314, Col 5 - Style/RedundantReturn - Redundant return detected.
• 🔶 - Line 332, Col 11 - Style/MultilineOperationIndentation - Align the operands of a condition in an if statement spanning multiple lines.
• 🔶 - Line 349, Col 11 - Style/LeadingCommentSpace - Missing space after #.
• 🔶 - Line 356, Col 5 - Style/RedundantReturn - Redundant return detected.
• 🔶 - Line 365, Col 9 - Style/MultilineOperationIndentation - Align the operands of a condition in an if statement spanning multiple lines.
• 🔶 - Line 392, Col 7 - Style/LeadingCommentSpace - Missing space after #.
• 🔶 - Line 393, Col 7 - Style/NegatedIf - Favor unless over if for negative conditions.
• 🔶 - Line 410, Col 15 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 416, Col 15 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 416, Col 26 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 416, Col 40 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 416, Col 52 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 421, Col 5 - Style/RedundantReturn - Redundant return detected.
• 🔹 - Line 1, Col 1 - Metrics/ClassLength - Class has too many lines. [422/100]
• 🔹 - Line 31, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for center_toolbar_filename_explorer is too high. [49.2/15]
• 🔹 - Line 31, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for center_toolbar_filename_explorer is too high. [31/6]
• 🔹 - Line 31, Col 3 - Metrics/MethodLength - Method has too many lines. [56/25]
• 🔹 - Line 31, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for center_toolbar_filename_explorer is too high. [32/7]
• 🔹 - Line 44, Col 11 - Metrics/BlockNesting - Avoid more than 3 levels of block nesting.
• 🔹 - Line 48, Col 19 - Metrics/BlockNesting - Avoid more than 3 levels of block nesting.
• 🔹 - Line 73, Col 18 - Metrics/BlockNesting - Avoid more than 3 levels of block nesting.
• 🔹 - Line 90, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for center_toolbar_filename_automate is too high. [9/6]
• 🔹 - Line 117, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for center_toolbar_filename_automate_customization is too high. [37.13/15]
• 🔹 - Line 117, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for center_toolbar_filename_automate_customization is too high. [18/6]
• 🔹 - Line 117, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for center_toolbar_filename_automate_customization is too high. [21/7]
• 🔹 - Line 144, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for center_toolbar_filename_services is too high. [33.63/15]
• 🔹 - Line 144, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for center_toolbar_filename_services is too high. [14/6]
• 🔹 - Line 144, Col 3 - Metrics/MethodLength - Method has too many lines. [34/25]
• 🔹 - Line 144, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for center_toolbar_filename_services is too high. [20/7]
• 🔹 - Line 185, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for center_toolbar_filename_chargeback is too high. [8/7]
• 🔹 - Line 198, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for center_toolbar_filename_miq_policy is too high. [17.46/15]
• 🔹 - Line 198, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for center_toolbar_filename_miq_policy is too high. [18/6]
• 🔹 - Line 198, Col 3 - Metrics/MethodLength - Method has too many lines. [26/25]
• 🔹 - Line 198, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for center_toolbar_filename_miq_policy is too high. [11/7]
• 🔹 - Line 227, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for center_toolbar_filename_ops is too high. [82.28/15]
• 🔹 - Line 227, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for center_toolbar_filename_ops is too high. [24/6]
• 🔹 - Line 227, Col 3 - Metrics/MethodLength - Method has too many lines. [50/25]
• 🔹 - Line 227, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for center_toolbar_filename_ops is too high. [29/7]
• 🔹 - Line 280, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for center_toolbar_filename_report is too high. [37.38/15]
• 🔹 - Line 280, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for center_toolbar_filename_report is too high. [16/6]
• 🔹 - Line 280, Col 3 - Metrics/MethodLength - Method has too many lines. [31/25]
• 🔹 - Line 280, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for center_toolbar_filename_report is too high. [19/7]
• 🔹 - Line 317, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for center_toolbar_filename_pxe is too high. [34.18/15]
• 🔹 - Line 317, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for center_toolbar_filename_pxe is too high. [13/6]
• 🔹 - Line 317, Col 3 - Metrics/MethodLength - Method has too many lines. [37/25]
• 🔹 - Line 317, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for center_toolbar_filename_pxe is too high. [20/7]
• 🔹 - Line 360, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for center_toolbar_filename_classic is too high. [46.67/15]
• 🔹 - Line 360, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for center_toolbar_filename_classic is too high. [34/6]
• 🔹 - Line 360, Col 3 - Metrics/MethodLength - Method has too many lines. [58/25]
• 🔹 - Line 360, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for center_toolbar_filename_classic is too high. [39/7]
• 🔹 - Line 399, Col 11 - Metrics/BlockNesting - Avoid more than 3 levels of block nesting.
• 🔹 - Line 411, Col 11 - Metrics/BlockNesting - Avoid more than 3 levels of block nesting.

spec/helpers/application_helper/toolbar_builder_spec.rb

• 🔴 Warn - Line 257, Col 11 - Lint/UselessAssignment - Useless assignment to variable - expected_buttons. Did you mean expected_button1?
• 🔴 Warn - Line 269, Col 11 - Lint/UselessAssignment - Useless assignment to variable - button2.
• 🔶 - Line 40, Col 74 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 50, Col 24 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 50, Col 50 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 53, Col 100 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 61, Col 33 - Style/IndentHash - Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
• 🔶 - Line 66, Col 68 - Style/DeprecatedHashMethods - Hash#has_key? is deprecated in favor of Hash#key?.
• 🔶 - Line 68, Col 30 - Style/IndentHash - Indent the right brace the same as the start of the line where the left brace is.
• 🔶 - Line 70, Col 35 - Style/IndentHash - Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
• 🔶 - Line 74, Col 73 - Style/DeprecatedHashMethods - Hash#has_key? is deprecated in favor of Hash#key?.
• 🔶 - Line 76, Col 33 - Style/IndentHash - Indent the right brace the same as the start of the line where the left brace is.
• 🔶 - Line 88, Col 23 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 88, Col 23 - Style/IndentHash - Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
• 🔶 - Line 89, Col 23 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 90, Col 23 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 91, Col 23 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 92, Col 23 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 93, Col 23 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 94, Col 23 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 95, Col 21 - Style/IndentHash - Indent the right brace the same as the start of the line where the left brace is.
• 🔶 - Line 98, Col 21 - Style/IndentHash - Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
• 🔶 - Line 104, Col 19 - Style/IndentHash - Indent the right brace the same as the start of the line where the left brace is.
• 🔶 - Line 105, Col 20 - Style/SpaceInsideBrackets - Space inside square brackets detected.
• 🔶 - Line 105, Col 37 - Style/SpaceInsideBrackets - Space inside square brackets detected.
• 🔶 - Line 107, Col 51 - Style/SpaceInsideBrackets - Space inside square brackets detected.
• 🔶 - Line 107, Col 82 - Style/SpaceInsideBrackets - Space inside square brackets detected.
• 🔶 - Line 113, Col 23 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 113, Col 23 - Style/IndentHash - Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
• 🔶 - Line 114, Col 23 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 115, Col 23 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 116, Col 23 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 117, Col 23 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 118, Col 23 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 119, Col 23 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 120, Col 21 - Style/IndentHash - Indent the right brace the same as the start of the line where the left brace is.
• 🔶 - Line 123, Col 21 - Style/IndentHash - Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
• 🔶 - Line 129, Col 19 - Style/IndentHash - Indent the right brace the same as the start of the line where the left brace is.
• 🔶 - Line 131, Col 34 - Style/IndentHash - Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
• 🔶 - Line 133, Col 32 - Style/IndentHash - Indent the right brace the same as the start of the line where the left brace is.
• 🔶 - Line 135, Col 60 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 135, Col 92 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 156, Col 74 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 166, Col 24 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 166, Col 63 - Style/SpaceBeforeComma - Space found before comma.

[miq-bot]

...continued

• 🔶 - Line 169, Col 113 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 178, Col 23 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 178, Col 23 - Style/IndentHash - Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
• 🔶 - Line 179, Col 23 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 180, Col 23 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 181, Col 23 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 182, Col 23 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 183, Col 23 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 184, Col 23 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 185, Col 21 - Style/IndentHash - Indent the right brace the same as the start of the line where the left brace is.
• 🔶 - Line 188, Col 21 - Style/IndentHash - Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
• 🔶 - Line 194, Col 19 - Style/IndentHash - Indent the right brace the same as the start of the line where the left brace is.
• 🔶 - Line 195, Col 20 - Style/SpaceInsideBrackets - Space inside square brackets detected.
• 🔶 - Line 195, Col 37 - Style/SpaceInsideBrackets - Space inside square brackets detected.
• 🔶 - Line 197, Col 51 - Style/SpaceInsideBrackets - Space inside square brackets detected.
• 🔶 - Line 197, Col 82 - Style/SpaceInsideBrackets - Space inside square brackets detected.
• 🔶 - Line 203, Col 23 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 203, Col 23 - Style/IndentHash - Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
• 🔶 - Line 204, Col 23 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 205, Col 23 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 206, Col 23 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 207, Col 23 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 208, Col 23 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 209, Col 23 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 210, Col 21 - Style/IndentHash - Indent the right brace the same as the start of the line where the left brace is.
• 🔶 - Line 213, Col 21 - Style/IndentHash - Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
• 🔶 - Line 219, Col 19 - Style/IndentHash - Indent the right brace the same as the start of the line where the left brace is.
• 🔶 - Line 221, Col 34 - Style/IndentHash - Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
• 🔶 - Line 223, Col 32 - Style/IndentHash - Indent the right brace the same as the start of the line where the left brace is.
• 🔶 - Line 225, Col 60 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 225, Col 92 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 227, Col 153 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 231, Col 23 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 231, Col 23 - Style/IndentHash - Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
• 🔶 - Line 232, Col 23 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 233, Col 23 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 234, Col 23 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 235, Col 23 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 236, Col 23 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 237, Col 23 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 238, Col 21 - Style/IndentHash - Indent the right brace the same as the start of the line where the left brace is.
• 🔶 - Line 240, Col 34 - Style/IndentHash - Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
• 🔶 - Line 242, Col 32 - Style/IndentHash - Indent the right brace the same as the start of the line where the left brace is.
• 🔶 - Line 244, Col 60 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 244, Col 92 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 249, Col 33 - Style/IndentHash - Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
• 🔶 - Line 254, Col 68 - Style/DeprecatedHashMethods - Hash#has_key? is deprecated in favor of Hash#key?.
• 🔶 - Line 256, Col 30 - Style/IndentHash - Indent the right brace the same as the start of the line where the left brace is.
• 🔶 - Line 259, Col 35 - Style/IndentHash - Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
• 🔶 - Line 263, Col 73 - Style/DeprecatedHashMethods - Hash#has_key? is deprecated in favor of Hash#key?.
• 🔶 - Line 265, Col 33 - Style/IndentHash - Indent the right brace the same as the start of the line where the left brace is.
• 🔶 - Line 269, Col 152 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 277, Col 150 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 279, Col 31 - Style/IndentHash - Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
• 🔶 - Line 284, Col 65 - Style/DeprecatedHashMethods - Hash#has_key? is deprecated in favor of Hash#key?.
• 🔶 - Line 286, Col 28 - Style/IndentHash - Indent the right brace the same as the start of the line where the left brace is.
• 🔶 - Line 289, Col 1 - Style/EmptyLinesAroundBlockBody - Extra empty line detected at block body end.
• 🔶 - Line 328, Col 7 - Style/LeadingCommentSpace - Missing space after #.
• 🔶 - Line 348, Col 14 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 348, Col 15 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 348, Col 28 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 348, Col 68 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 349, Col 39 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 415, Col 18 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 415, Col 33 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 420, Col 18 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 420, Col 41 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 425, Col 5 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 425, Col 19 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 429, Col 20 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 429, Col 43 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 434, Col 20 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 434, Col 35 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 445, Col 5 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 526, Col 5 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 526, Col 27 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 527, Col 9 - Style/AlignArray - Align the elements of an array literal if they span more than one line.
• 🔶 - Line 527, Col 40 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 527, Col 64 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 528, Col 9 - Style/AlignArray - Align the elements of an array literal if they span more than one line.
• 🔶 - Line 528, Col 24 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 528, Col 38 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 529, Col 9 - Style/AlignArray - Align the elements of an array literal if they span more than one line.
• 🔶 - Line 530, Col 9 - Style/AlignArray - Align the elements of an array literal if they span more than one line.
• 🔶 - Line 530, Col 21 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 530, Col 33 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 531, Col 9 - Style/AlignArray - Align the elements of an array literal if they span more than one line.
• 🔶 - Line 532, Col 9 - Style/AlignArray - Align the elements of an array literal if they span more than one line.
• 🔶 - Line 533, Col 9 - Style/AlignArray - Align the elements of an array literal if they span more than one line.
• 🔶 - Line 534, Col 9 - Style/AlignArray - Align the elements of an array literal if they span more than one line.
• 🔶 - Line 535, Col 9 - Style/AlignArray - Align the elements of an array literal if they span more than one line.
• 🔶 - Line 536, Col 9 - Style/AlignArray - Align the elements of an array literal if they span more than one line.
• 🔶 - Line 537, Col 9 - Style/AlignArray - Align the elements of an array literal if they span more than one line.
• 🔶 - Line 538, Col 9 - Style/AlignArray - Align the elements of an array literal if they span more than one line.
• 🔶 - Line 539, Col 9 - Style/AlignArray - Align the elements of an array literal if they span more than one line.
• 🔶 - Line 540, Col 9 - Style/AlignArray - Align the elements of an array literal if they span more than one line.
• 🔶 - Line 541, Col 9 - Style/AlignArray - Align the elements of an array literal if they span more than one line.
• 🔶 - Line 542, Col 9 - Style/AlignArray - Align the elements of an array literal if they span more than one line.
• 🔶 - Line 543, Col 9 - Style/AlignArray - Align the elements of an array literal if they span more than one line.
• 🔶 - Line 544, Col 9 - Style/AlignArray - Align the elements of an array literal if they span more than one line.
• 🔶 - Line 545, Col 9 - Style/AlignArray - Align the elements of an array literal if they span more than one line.
• 🔶 - Line 546, Col 9 - Style/AlignArray - Align the elements of an array literal if they span more than one line.
• 🔶 - Line 547, Col 9 - Style/AlignArray - Align the elements of an array literal if they span more than one line.
• 🔶 - Line 548, Col 9 - Style/AlignArray - Align the elements of an array literal if they span more than one line.
• 🔶 - Line 549, Col 9 - Style/AlignArray - Align the elements of an array literal if they span more than one line.
• 🔶 - Line 560, Col 18 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 560, Col 35 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 569, Col 16 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 569, Col 17 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 569, Col 28 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 569, Col 66 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 570, Col 15 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 570, Col 41 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 573, Col 16 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 573, Col 17 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 573, Col 28 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 573, Col 62 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 574, Col 15 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 574, Col 41 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 579, Col 16 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 579, Col 17 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 579, Col 28 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 579, Col 72 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 580, Col 15 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 580, Col 41 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 585, Col 16 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 585, Col 17 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 585, Col 28 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 585, Col 79 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 586, Col 15 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 586, Col 41 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 591, Col 16 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 591, Col 17 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 591, Col 28 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 591, Col 80 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 592, Col 15 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 592, Col 41 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 600, Col 18 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 600, Col 35 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 609, Col 16 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 609, Col 17 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 609, Col 28 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 609, Col 72 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 610, Col 15 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 610, Col 41 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 613, Col 16 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 613, Col 17 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 613, Col 28 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 613, Col 62 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 614, Col 15 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 614, Col 41 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 619, Col 16 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 619, Col 17 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 619, Col 28 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 619, Col 79 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 620, Col 15 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 620, Col 41 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 625, Col 16 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 625, Col 17 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 625, Col 28 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 625, Col 80 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 626, Col 15 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 626, Col 41 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 631, Col 16 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 631, Col 17 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 631, Col 28 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 631, Col 85 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 632, Col 15 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 632, Col 41 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 640, Col 18 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 640, Col 35 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 649, Col 16 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 649, Col 17 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 649, Col 28 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 649, Col 72 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 650, Col 15 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 650, Col 41 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 653, Col 16 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 653, Col 17 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 653, Col 28 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 653, Col 71 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 654, Col 15 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 654, Col 41 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 657, Col 16 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.

[miq-bot]

...continued

• 🔶 - Line 657, Col 17 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 657, Col 28 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 657, Col 62 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 658, Col 15 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 658, Col 41 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 663, Col 16 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 663, Col 17 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 663, Col 28 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 663, Col 79 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 664, Col 15 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 664, Col 41 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 672, Col 18 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 672, Col 35 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 687, Col 16 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 687, Col 17 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 687, Col 28 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 687, Col 79 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 688, Col 15 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 689, Col 15 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 689, Col 33 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 698, Col 18 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 698, Col 35 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 699, Col 16 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 699, Col 17 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 699, Col 28 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 699, Col 79 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 700, Col 15 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 718, Col 16 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 718, Col 17 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 718, Col 28 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 718, Col 66 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 719, Col 15 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 728, Col 5 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 728, Col 19 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 728, Col 35 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 728, Col 49 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 736, Col 20 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 736, Col 59 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 746, Col 5 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 793, Col 25 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 793, Col 40 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 798, Col 25 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 798, Col 38 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 798, Col 72 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 798, Col 74 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 804, Col 25 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 804, Col 38 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 804, Col 68 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 804, Col 70 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 821, Col 25 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 821, Col 40 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 826, Col 25 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 826, Col 38 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 826, Col 72 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 826, Col 74 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 832, Col 25 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 832, Col 38 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 832, Col 68 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 832, Col 70 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 849, Col 25 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 849, Col 40 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 854, Col 25 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 854, Col 38 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 854, Col 73 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 854, Col 75 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 860, Col 25 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 860, Col 38 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 860, Col 69 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 860, Col 71 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 865, Col 5 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 873, Col 27 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 873, Col 41 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 873, Col 56 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 873, Col 58 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 878, Col 27 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 878, Col 41 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 878, Col 55 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 878, Col 57 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 987, Col 7 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 987, Col 23 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 987, Col 38 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 987, Col 52 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 987, Col 100 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 987, Col 113 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 987, Col 125 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 1005, Col 7 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 1009, Col 30 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 1009, Col 49 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 1013, Col 30 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 1013, Col 46 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 1024, Col 5 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 1024, Col 27 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 1024, Col 77 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 1227, Col 7 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 1227, Col 20 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 1227, Col 35 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 1227, Col 52 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 1228, Col 9 - Style/AlignArray - Align the elements of an array literal if they span more than one line.
• 🔶 - Line 1228, Col 23 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 1228, Col 38 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 1228, Col 52 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 1228, Col 65 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 1228, Col 81 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 1228, Col 106 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 1247, Col 7 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 1272, Col 7 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 1272, Col 23 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 1272, Col 36 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 1272, Col 51 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 1272, Col 68 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 1362, Col 7 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 1476, Col 7 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 1476, Col 23 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 1535, Col 7 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 1539, Col 30 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 1539, Col 49 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 1543, Col 30 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 1543, Col 46 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 1582, Col 7 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 1582, Col 33 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 1642, Col 28 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 1642, Col 44 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 1647, Col 28 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 1647, Col 47 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 1651, Col 9 - Style/LeadingCommentSpace - Missing space after #.
• 🔶 - Line 1659, Col 7 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 1679, Col 7 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 1704, Col 7 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 1729, Col 7 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 1734, Col 31 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 1734, Col 48 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 1740, Col 31 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 1740, Col 66 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 1746, Col 31 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 1746, Col 66 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 1752, Col 7 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 1793, Col 1 - Style/EmptyLinesAroundBlockBody - Extra empty line detected at block body end.
• 🔶 - Line 1835, Col 5 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 1844, Col 5 - Style/IndentationWidth - Use 2 (not 4) spaces for indentation.
• 🔶 - Line 1844, Col 16 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 1844, Col 17 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 1844, Col 30 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 1844, Col 56 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 1845, Col 41 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 1849, Col 5 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 1860, Col 16 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 1861, Col 17 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 1861, Col 28 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 1861, Col 51 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 1861, Col 78 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 1862, Col 51 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 1870, Col 95 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 1870, Col 109 - Style/SpaceInsideParens - Space inside parentheses detected.
• 🔶 - Line 2032, Col 43 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 2032, Col 48 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 2153, Col 46 - Style/SpaceInsideBrackets - Space inside square brackets detected.
• 🔶 - Line 2153, Col 98 - Style/SpaceInsideParens - Space inside parentheses detected.
• 🔶 - Line 2175, Col 43 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 2315, Col 7 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 2315, Col 47 - Style/SpaceAroundBlockParameters - Space before first block parameter detected.
• 🔶 - Line 2315, Col 57 - Style/SpaceAroundBlockParameters - Space after last block parameter detected.
• 🔶 - Line 2372, Col 13 - Style/IndentationWidth - Use 2 (not 4) spaces for indentation.
• 🔶 - Line 2374, Col 15 - Style/IndentationConsistency - Inconsistent indentation detected.
• 🔶 - Line 2433, Col 7 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 2433, Col 25 - Style/SpaceAfterComma - Space missing after comma.
• 🔶 - Line 2520, Col 7 - Style/LeadingCommentSpace - Missing space after #.
• 🔶 - Line 2530, Col 22 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 2531, Col 20 - Style/SpaceAroundOperators - Operator == should be surrounded with a single space.
• 🔶 - Line 2569, Col 5 - Style/WordArray - Use %w or %W for array of words.
• 🔶 - Line 2615, Col 1 - Style/EmptyLinesAroundBlockBody - Extra empty line detected at block body end.
• 🔶 - Line 2623, Col 16 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 2623, Col 17 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 2623, Col 24 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 2624, Col 21 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 2624, Col 25 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 2625, Col 21 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• 🔶 - Line 2625, Col 31 - Style/SpaceAroundOperators - Surrounding space missing for operator =>.
• 🔶 - Line 2627, Col 21 - Style/EmptyLiteral - Use hash literal {} instead of Hash.new.
• 🔶 - Line 2634, Col 15 - Style/BlockDelimiters - Avoid using {...} for multi-line blocks.
• 🔶 - Line 2655, Col 15 - Style/BlockDelimiters - Avoid using {...} for multi-line blocks.
• 🔶 - Line 2678, Col 41 - Style/SpaceInsideParens - Space inside parentheses detected.
• 🔶 - Line 2683, Col 40 - Style/SpaceInsideParens - Space inside parentheses detected.
• 🔶 - Line 2688, Col 15 - Style/BlockDelimiters - Avoid using {...} for multi-line blocks.
• 🔶 - Line 2694, Col 18 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• 🔶 - Line 2694, Col 83 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• 🔶 - Line 2695, Col 32 - Style/SpaceInsideParens - Space inside parentheses detected.
• 🔶 - Line 2695, Col 63 - Style/SpaceInsideParens - Space inside parentheses detected.
• 🔶 - Line 2705, Col 1 - Style/EmptyLinesAroundBlockBody - Extra empty line detected at block body beginning.
• 🔹 - Line 53, Col 121 - Metrics/LineLength - Line is too long. [137/120]
• 🔹 - Line 66, Col 121 - Metrics/LineLength - Line is too long. [122/120]
• 🔹 - Line 74, Col 121 - Metrics/LineLength - Line is too long. [131/120]

[miq-bot]

...continued

• 🔹 - Line 94, Col 121 - Metrics/LineLength - Line is too long. [158/120]
• 🔹 - Line 119, Col 121 - Metrics/LineLength - Line is too long. [158/120]
• 🔹 - Line 169, Col 121 - Metrics/LineLength - Line is too long. [150/120]
• 🔹 - Line 184, Col 121 - Metrics/LineLength - Line is too long. [158/120]
• 🔹 - Line 209, Col 121 - Metrics/LineLength - Line is too long. [158/120]
• 🔹 - Line 227, Col 121 - Metrics/LineLength - Line is too long. [190/120]
• 🔹 - Line 237, Col 121 - Metrics/LineLength - Line is too long. [158/120]
• 🔹 - Line 254, Col 121 - Metrics/LineLength - Line is too long. [122/120]
• 🔹 - Line 263, Col 121 - Metrics/LineLength - Line is too long. [131/120]
• 🔹 - Line 269, Col 121 - Metrics/LineLength - Line is too long. [189/120]
• 🔹 - Line 277, Col 121 - Metrics/LineLength - Line is too long. [187/120]
• 🔹 - Line 865, Col 121 - Metrics/LineLength - Line is too long. [151/120]
• 🔹 - Line 987, Col 121 - Metrics/LineLength - Line is too long. [151/120]
• 🔹 - Line 1024, Col 121 - Metrics/LineLength - Line is too long. [166/120]
• 🔹 - Line 1189, Col 121 - Metrics/LineLength - Line is too long. [135/120]
• 🔹 - Line 1228, Col 121 - Metrics/LineLength - Line is too long. [137/120]
• 🔹 - Line 1900, Col 121 - Metrics/LineLength - Line is too long. [173/120]
• 🔹 - Line 1933, Col 121 - Metrics/LineLength - Line is too long. [125/120]
• 🔹 - Line 2011, Col 121 - Metrics/LineLength - Line is too long. [125/120]
• 🔹 - Line 2082, Col 121 - Metrics/LineLength - Line is too long. [122/120]
• 🔹 - Line 2168, Col 121 - Metrics/LineLength - Line is too long. [122/120]
• 🔹 - Line 2223, Col 121 - Metrics/LineLength - Line is too long. [122/120]
• 🔹 - Line 2625, Col 121 - Metrics/LineLength - Line is too long. [128/120]
• 🔹 - Line 2693, Col 121 - Metrics/LineLength - Line is too long. [126/120]

[chessbyte]

@martinpovolny @dclarizio Any update on this PR? Agree with @Fryguy that this is a nice refactoring that would be good to get merged, if refactored code works.

[dclarizio]

Ran the UI in this branch a bit and the toolbars seem to be functioning properly and obeying RBAC.