[api] Add chargebacks to the API. #3611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imtayadeway
changed the title
|
@miq-bot remove_label wip |
|
@abellotti Please review |
| "description" => chargeback_rate.description, | ||
| "guid" => chargeback_rate.guid, | ||
| "id" => chargeback_rate.id, | ||
| "href" => "http://example.org/api/chargebacks/#{chargeback_rate.to_param}" |
There was a problem hiding this comment.
no need for full path here, you can just have "href" => chargebacks_url(chargeback_rate.to_param)
|
Checked commits imtayadeway@7b06e8d .. imtayadeway@796b79b with rubocop 0.32.1 and haml-lint 0.13.0 |
|
👍 Looks good, will merge when green. |
abellotti
added a commit
that referenced
this pull request
Jul 31, 2015
[api] Add chargebacks to the API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/6j2aiL16
https://bugzilla.redhat.com/show_bug.cgi?id=1238271
cc/ @abellotti @gtanzillo