MiqSystem.disk_usage learned to accept a path containing space(s) #3655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to convert these runcmd calls to use AwesomeSpawn to fix quoting issues. Since swapinfo isn't called and is lacking tests, let's delete this and add it when we know what we need. Preliminary for Postgresql 9.4 support: https://trello.com/c/Mk4DhnCW
Fixes running "df" with a file/directory path with a space. I saw this when running Postgres.app where my data directory has space(s): `/Applications/Postgres.app/Contents/Versions/9.4/bin/postgres -D /Users/username/Library/Application Support/Postgres/var-9.4` Preliminary for Postgresql 9.4 support: https://trello.com/c/Mk4DhnCW
|
@chessbyte @Fryguy please review, I couldn't find uses of swapinfo and deleting unused code is 😍 and made it easier to convert these commands to AwesomeSpawn for the shell quoting. |
|
Checked commits jrafanie@0215938 .. jrafanie@b34fed3 with rubocop 0.32.1 and haml-lint 0.13.0 |
Fryguy
added a commit
that referenced
this pull request
Jul 30, 2015
MiqSystem.disk_usage learned to accept a path containing space(s)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete unused MiqSystem.swapinfo
We need to convert these runcmd calls to use AwesomeSpawn to fix quoting issues.
Since swapinfo isn't called and is lacking tests, let's delete this and add it
when we know what we need.
Use AwesomeSpawn.run! to deal with shell escaping
Fixes running "df" with a file/directory path with a space.
I saw this when running Postgres.app where my data directory has space(s):
/Applications/Postgres.app/Contents/Versions/9.4/bin/postgres -D /Users/username/Library/Application Support/Postgres/var-9.4Preliminary for Postgresql 9.4 support:
https://trello.com/c/Mk4DhnCW