Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed to load correct screen when pressing buttons under Lifecycle. #4412

Merged

Conversation

h-kataria
Copy link
Contributor

When pressing Publish, Migrate, Clone buttons under Lifecycle toolbar button from list of VMs under a Provider thru relationship was loading pre provisioning dialog, it should load the workflow dialog directly. Pre-provisioning dialog is only supposed to show when Adding a new Provisioning request directly from VM explorers.

https://bugzilla.redhat.com/show_bug.cgi?id=1263845

@dclarizio please review.

before:
Migrate VMs under provider -
provider_vms_migrate
Migrate directly from VMx -
vmx

after:
Migrate VMs under provider -
after_fix

When pressing Publish, Migrate, Clone buttons under Lifecycle toolbar button from list of VMs under a Provider thru relationship was loading pre provisioning dialog, it should load the workflow dialog directly. Pre-provisioning dialog is only supposed to show when Adding a new Provisioning request directly from VM explorers.

https://bugzilla.redhat.com/show_bug.cgi?id=1263845
@chessbyte chessbyte changed the title Fixed to load correct screen when pressing button sunder Lifecycle. Fixed to load correct screen when pressing buttons under Lifecycle. Sep 17, 2015
@miq-bot
Copy link
Member

miq-bot commented Sep 17, 2015

Checked commit h-kataria@f16094b with ruby 1.9.3, rubocop 0.33.0, and haml-lint 0.13.0
3 files checked, 0 offenses detected
Everything looks good. 🍪

dclarizio pushed a commit that referenced this pull request Sep 21, 2015
…ublists

Fixed to load correct screen when pressing buttons under Lifecycle.
@dclarizio dclarizio merged commit 74a8332 into ManageIQ:master Sep 21, 2015
@dclarizio dclarizio deleted the fixed_lifecycle_buttons_for_sublists branch September 21, 2015 22:06
@dclarizio dclarizio added this to the Sprint 30 Ending Oct 5, 2015 milestone Sep 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants