Update to use azure-armrest version 0.0.6 #5073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -21,7 +21,7 @@ def self.make_create_options(template, options) | |||
| create_options[:parameters] = create_options[:parameters].map { |k, v| [k, {'value' => v}] }.to_h | |||
| end | |||
|
|
|||
| return resource_group, create_options | |||
| return resource_group, 'properties' => create_options | |||
There was a problem hiding this comment.
armrest gem no longer automatically insert properties key if missing.
bzwei
force-pushed
the
switch_new_armrest
branch
from
bf5438a
to
2c3b0fa
Compare
| @@ -235,27 +249,29 @@ def add_instance_disk(disks, size, name, location) | |||
| super(disks, size, name, location, "azure") | |||
| end | |||
|
|
|||
| def populate_hardware_hash_with_networks(hardware_networks_array, instance) | |||
| nics = instance.fetch_path('properties', 'networkProfile', 'networkInterfaces') | |||
| def populate_hardware_hash_with_networks(networks_array, instance) | |||
There was a problem hiding this comment.
Rewrote the whole implementation. The armrest gem no longer queries network ip addresses and inserts to the vm object. Make explicit calls here to get them.
|
Looks good to me Bill. I think the rubocop issues are the only thing you'll need to deal with. |
|
LGTM |
Update Azure refresh logic due to the changes in armrest gem
bzwei
force-pushed
the
switch_new_armrest
branch
from
2c3b0fa
to
93bb6a2
Compare
|
<github_pr_commenter_batch />Some comments on commit bzwei@93bb6a2 |
|
Checked commit bzwei@93bb6a2 with ruby 1.9.3, rubocop 0.34.2, and haml-lint 0.13.0 app/models/manageiq/providers/azure/cloud_manager/refresh_parser.rb
spec/models/manageiq/providers/azure/cloud_manager/orchestration_stack_spec.rb
spec/models/manageiq/providers/azure/cloud_manager/refresher_spec.rb
spec/models/manageiq/providers/azure/cloud_manager_spec.rb
|
chessbyte
added a commit
that referenced
this pull request
Oct 23, 2015
Update to use azure-armrest version 0.0.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Azure refresh logic due to the changes in armrest gem
Add links between cloud networks and stacks.