Add :select to legacy finder options #5211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caused issues when find was called like is is here https://github.com/ManageIQ/manageiq/blob/8007cc50bc45ffb509154957960600486477aee7/app/models/vim_performance_analysis.rb#L530 https://bugzilla.redhat.com/show_bug.cgi?id=1267749
carbonin
force-pushed
the
add_select_to_legacy_finder_options
branch
from
9c8d15b
to
a418611
Compare
|
Checked commit carbonin@a418611 with ruby 1.9.3, rubocop 0.34.2, and haml-lint 0.13.0 |
|
👍 Looks good |
gtanzillo
added a commit
that referenced
this pull request
Oct 30, 2015
…tions Add :select to legacy finder options
gtanzillo
added a commit
that referenced
this pull request
Nov 10, 2015
…tions Add :select to legacy finder options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused issues when find was called like is is here
manageiq/app/models/vim_performance_analysis.rb
Line 530 in 8007cc5
https://bugzilla.redhat.com/show_bug.cgi?id=1267749