Automate | Consolidated Quota | Fix cloud requested values. #5267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinaafitz
force-pushed
the
quota_fixes
branch
from
1117292
to
2193200
Compare
| end | ||
|
|
||
| def cloud_vm_memory(vmdb_object_find_by, dialog_array) | ||
| flavor = vmdb_object(:flavor, vmdb_object_find_by) |
There was a problem hiding this comment.
@tinaafitz
Can we get the flavor object just once for the cloud and pass it around
tinaafitz
force-pushed
the
quota_fixes
branch
3 times, most recently
from
b89859a
to
cf070c2
Compare
| @@ -8,9 +8,13 @@ def request_info | |||
| $evm.log(:info, "Request: #{@miq_request.description} id: #{@miq_request.id} ") | |||
| end | |||
|
|
|||
| def cloud?(prov_type) | |||
| prov_type == "amazon" || prov_type == "openstack" ? true : false | |||
There was a problem hiding this comment.
@tinaafitz This might be better
%w(amazon openstack).include?(prov_type)
tinaafitz
force-pushed
the
quota_fixes
branch
from
cf070c2
to
e235e81
Compare
|
👍 |
tinaafitz
force-pushed
the
quota_fixes
branch
3 times, most recently
from
57a5df4
to
c219422
Compare
| end | ||
| end | ||
| options_array | ||
| end | ||
|
|
||
| def service_prov_option_value(prov_option, resource, options_array = []) | ||
| args_hash = {:prov_option => prov_option, | ||
| :array => options_array, |
There was a problem hiding this comment.
@tinaafitz This should be more descriptive than just array. Seems like it should at least be options_array based on the other key names here.
tinaafitz
force-pushed
the
quota_fixes
branch
from
c219422
to
4b953db
Compare
|
@gmcculloug |
| set_requested_value(prov_option, resource.get_option(prov_option), | ||
| resource.get_option(:instance_type), options_array) | ||
| def request_object?(object) | ||
| return false if object.nil? |
There was a problem hiding this comment.
@tinaafitz This check is not needed since object.respond_to?('get_option') would already return false if object is nil.
tinaafitz
force-pushed
the
quota_fixes
branch
from
4b953db
to
449991e
Compare
|
@gmcculloug |
|
Checked commit tinaafitz@449991e with ruby 1.9.3, rubocop 0.34.2, and haml-lint 0.13.0 |
|
👍 |
gmcculloug
added a commit
that referenced
this pull request
Nov 16, 2015
Automate | Consolidated Quota | Fix cloud requested values.
blomquisg
pushed a commit
to blomquisg/manageiq
that referenced
this pull request
Nov 23, 2015
Fix cloud requested values and fixed spec test to reflect changes. ManageIQ#5267 https://bugzilla.redhat.com/show_bug.cgi?id=1254882 Clean cherry-pick. Also resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1248747 https://bugzilla.redhat.com/show_bug.cgi?id=1254211 https://bugzilla.redhat.com/show_bug.cgi?id=1126934 https://bugzilla.redhat.com/show_bug.cgi?id=1273919 https://bugzilla.redhat.com/show_bug.cgi?id=1263592 See merge request !481
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed VM quota issue where cloud requested values were zero.
https://bugzilla.redhat.com/show_bug.cgi?id=1254882