Show Tenant column in catalog item's Request info tab only when relevant #5283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the key is defined this changes MiqHashStruct's respond_to_missing? to return false unless the method is a setter or the key is defined. That is, code like MiqHashStruct.new(:foo => 1).respond_to? :bar will no longer return true. https://bugzilla.redhat.com/show_bug.cgi?id=1275514
|
👍 LGTM |
|
Checked commits https://github.com/himdel/manageiq/compare/b579ac39833a50025e2cf207ffdd526299b6caee~...8fc45cd8f8370f1760f800a4a4502bd507d74af6 with ruby 1.9.3, rubocop 0.34.2, and haml-lint 0.13.0 |
dclarizio
pushed a commit
that referenced
this pull request
Nov 4, 2015
Show Tenant column in catalog item's Request info tab only when relevant
dclarizio
pushed a commit
that referenced
this pull request
Nov 10, 2015
Show Tenant column in catalog item's Request info tab only when relevant
simaishi
pushed a commit
that referenced
this pull request
Mar 19, 2019
…rom_VmOrTemplate_yaml_report [Performance] Remove compliance from VmOrTemplate includes (cherry picked from commit f39659c) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1690610
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1275514
There was an extra column for Tenant in prov_vm_grid, that was never filled in...
The headers in there come from
build_vm_gridwhich uses.respond_to?to determine whether there should be a Tenant field for a given set of VMs. Since #3816, MiqHashStruct'srespond_to?always returns true - this fixes it to only return true if the method is a setter or the field is actually already present in the hash. - ping @bdunneAlso, this adds the missing fields for the case when the Tenant column should be there.