Fixed condition in show_adv_search? method #5440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Some explorer screens such as Automate/Simulation do not have tree on the left, there is no need to check whether to display advanced search on those screens. - Added spec test to verify fix. https://bugzilla.redhat.com/show_bug.cgi?id=1281860
|
Checked commit h-kataria@fb5f460 with ruby 1.9.3, rubocop 0.34.2, and haml-lint 0.13.0 app/helpers/application_helper.rb
spec/helpers/application_helper_spec.rb
|
dclarizio
pushed a commit
that referenced
this pull request
Nov 13, 2015
Fixed condition in show_adv_search? method
dclarizio
pushed a commit
that referenced
this pull request
Nov 17, 2015
Fixed condition in show_adv_search? method
blomquisg
pushed a commit
to blomquisg/manageiq
that referenced
this pull request
Nov 23, 2015
Adv search fixes ManageIQ#5406 https://bugzilla.redhat.com/show_bug.cgi?id=1273032 https://bugzilla.redhat.com/show_bug.cgi?id=1281477 commits: ``` 2432e79 1e7ab38 ba5ea1a b02d35b cc0f2a5 2c8179f 9d2ca9c ``` ManageIQ#5440 https://bugzilla.redhat.com/show_bug.cgi?id=1281860 commits: ``` fb5f460 ``` command: git cherry-pick 2432e7 1e7ab3 ba5ea1 b02d35 cc0f2a 2c8179 9d2ca9 fb5f46 See merge request !470
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1281860
@dclarizio please review