Handle delimiters passed through as text into the web service #5491
Conversation
|
@gmcculloug - Please review |
|
@miq-bot add_label provisioning |
|
Checked commit syncrou@52a8091 with ruby 1.9.3, rubocop 0.34.2, and haml-lint 0.13.0 app/models/miq_request_workflow.rb
|
|
@miq-bot add_label enhancement |
|
@syncrou Need to look into the test failures. |
|
@jeffwarnica No, nothing wrong with those but this makes me realize that we might be able to bypass string parsing completely and just pass arrays or hashes here. The string implementation was based around a SOAP API which is no longer in the product. If the call is coming from Rest or Automate it would be easy to allow the caller to send objects instead of a string that requires parsing. @syncrou Let's pair and see if this approach is viable. |
|
Thanks to @abellotti and the work he did for the REST API passing a hash is already supported based on PR #260 (REST API Enhancement to support Provisioning). The change to parsing accepts a hash and converts it into the expected format. This is already used by REST and can be passed for automate as well. |
parse_ws_string always accepted arguments as a hash And in the case of this bug: sending multiple '|' delimited arguments as a hash solves the original problem. This fix adds deprecation warnings to parse_ws_string when arguments are sent as a string - noting the solution in the warning text.
syncrou
force-pushed
the
escape_ws_values
branch
from
52a8091
to
f29733e
Compare
https://bugzilla.redhat.com/show_bug.cgi?id=1277734
Modified the parse_ws_string method to handle input
that includes delimiters.
A customer can now include a delimiter (namely '|' (pipes))
as text passed into the web service and the string will no
longer be mangled.