Fixed the angular rendering issue at startup that is sometimes visible #5543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AparnaKarve
force-pushed
the
fix_angular_form_startup_render
branch
from
6e6fad3
to
414817e
Compare
|
@h-kataria Can you review this ? |
|
@AparnaKarve as discussed i am seeing some form rendering delay on Cloud Provider edit screen, can you try this at your end. Other 2 forms are working fine. |
Also added focus on first element in the form
Also added focus on first element in the form
AparnaKarve
force-pushed
the
fix_angular_form_startup_render
branch
from
414817e
to
c18ec54
Compare
|
Checked commits AparnaKarve/manageiq@f60b621~...c18ec54 with ruby 2.2.3, rubocop 0.34.2, and haml-lint 0.13.0 app/views/host/_form.html.haml
|
|
verified fix. |
h-kataria
added a commit
that referenced
this pull request
Dec 4, 2015
…nder Fixed the angular rendering issue at startup that is sometimes visible
dclarizio
pushed a commit
to dclarizio/manageiq
that referenced
this pull request
Dec 16, 2015
Fixed the angular rendering issue at startup that is sometimes visible https://bugzilla.redhat.com/show_bug.cgi?id=1290016 Clean cherry-pick. Upstream PR - ManageIQ#5543 The auto-focus directive will now be deployed to set the display 'on' on the form once all the json data is fetched. The directive will then set focus on the first field in the form. This is being done in order to resolve a known problem with angular forms where just before the form loads, for a brief second or so, the fields are marked red since the form json data is still being fetched from the server. This issue is quite pronounced on slower machines. See merge request !596
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a Part II for PR - #5048 and covers
Host,Cloud ProviderandProvider Foremanforms.