core: fix start_event_monitor logic #5626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases `@tid` could be dead (not `alive?`) but still have a
`status`, which would lead to an infinite loop.
In fact:
@tid ||= start_event_monitor
would never `start` a new `event_monitor` (since `@tid` already has
value), and:
if @tid.status.nil?
dead_tid, @tid = @tid, nil
...
would never take place as `@tid.status` is not `nil` resulting in an
infinite loop.
Signed-off-by: Federico Simoncelli <fsimonce@redhat.com>
|
@miq-bot add_label core, bug |
|
Checked commit simon3z@aedb823 with ruby 1.9.3, rubocop 0.34.2, and haml-lint 0.13.0 |
matthewd
added a commit
that referenced
this pull request
Nov 30, 2015
core: fix start_event_monitor logic
dclarizio
pushed a commit
to dclarizio/manageiq
that referenced
this pull request
Dec 16, 2015
core: fix start_event_monitor logic
In some cases `@tid` could be dead (not `alive?`) but still have a
`status`, which would lead to an infinite loop.
In fact:
@tid ||= start_event_monitor
would never `start` a new `event_monitor` (since `@tid` already has
value), and:
if @tid.status.nil?
dead_tid, @tid = @tid, nil
...
would never take place as `@tid.status` is not `nil` resulting in an
infinite loop.
Upstream: ManageIQ#5626
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1285341
See merge request !556
matthewd
added a commit
that referenced
this pull request
Jan 7, 2016
core: fix start_event_monitor logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases
@tidcould be dead (notalive?) but still have astatus, which would lead to an infinite loop.In fact:
would never
starta newevent_monitor(since@tidalready has value), and:would never take place as
@tid.statusis notnilresulting in an infinite loop.This issue was introduced in #4939
cc @jvlcek @Fryguy @chessbyte @blomquisg