Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] use bower-rails instead of rails-assets #5640

Closed
wants to merge 4 commits into from
Closed

[WIP] use bower-rails instead of rails-assets #5640

wants to merge 4 commits into from

Conversation

himdel
Copy link
Contributor

@himdel himdel commented Nov 30, 2015

This PR replaces rails-assets with bower-rails. Not meant for merging now, only to try out bower-rails, for the eventuality rails-assets dies....

The only real issue so far is that some files are no longer found at the right path and had to be fixed in application.(js|css). And bower packages not found in the registry are not "user--package", "version" but "package", "user/package#version".

And be rake bower:install is used instead of bundle install.

@miq-bot
Copy link
Member

miq-bot commented Dec 8, 2015

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented Dec 9, 2015

<github_pr_commenter_batch />Some comments on commits https://github.com/himdel/manageiq/compare/f56175b04698386ca816bd197293b52dea21f6b8~...322a2623ea0ce3d2899e75e7ea835af3952e6988

@miq-bot
Copy link
Member

miq-bot commented Dec 9, 2015

Checked commits https://github.com/himdel/manageiq/compare/f56175b04698386ca816bd197293b52dea21f6b8~...322a2623ea0ce3d2899e75e7ea835af3952e6988 with ruby 2.2.3, rubocop 0.34.2, and haml-lint 0.13.0
2 files checked, 1 offense detected

config/initializers/bower_rails.rb

@miq-bot
Copy link
Member

miq-bot commented Dec 10, 2015

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

@himdel
Copy link
Contributor Author

himdel commented Mar 29, 2016

will close in favor of #7577

@himdel himdel closed this Mar 30, 2016
@himdel himdel deleted the bower-rails branch March 30, 2016 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants