-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Replace angularjs-rails dependency with rails-assets-* #3773
Conversation
gem 'rails-assets-angular-route', '~> 1.4.3' | ||
gem 'rails-assets-angular-sanitize', '~> 1.4.3' | ||
gem 'rails-assets-angular-scenario', '~> 1.4.3' | ||
gem 'rails-assets-angular-touch', '~> 1.4.3' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting...do we actually use all this stuff?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really, it's just all the stuff angularjs-rails adds. It's just that a quick search didn't show me mocks
which I know we use, so I want to go through them properly to be sure
the same for angular-ui-bootstrap
…ssets Fixed the low-hanging fruit, now only the big stuff.
gem 'codemirror-rails', "=4.2" | ||
gem 'lodash-rails', '~> 3.10.0' | ||
|
||
# On MS Windows run "bundle config --local build.libv8 --with-system-v8" first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@himdel, libv8. We've dropped that, though, right? If so, you can remove that comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it's not in any Gemfile I can see, so removing :)
<gemfile_checker />Gemfile changes detected in commits https://github.com/himdel/manageiq/commit/a41b908c90dc630ecda8e4c1e3f25b7d655c139a .. https://github.com/himdel/manageiq/commit/c290cb9e029c1ff440dacd2abbc537d709afd373. /cc @JPrause @simaishi |
Checked commits https://github.com/himdel/manageiq/commit/a41b908c90dc630ecda8e4c1e3f25b7d655c139a .. https://github.com/himdel/manageiq/commit/c290cb9e029c1ff440dacd2abbc537d709afd373 with rubocop 0.32.1 and haml-lint 0.13.0 Gemfile.client.rb
|
<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush. |
closing in favor of whatever replaces #5640 |
This is to replace (ideally) all client-side dependencies with rails-assets-* versions.
I've moved them to a separate file - Gemfile.client.rb - to keep them separated.
Current TODO: