Support Azure VM retirement

app/models/manageiq/providers/azure/cloud_manager/refresh_parser.rb

@@ -225,7 +225,7 @@ def parse_instance(instance)
           :uid_ems             => uid,
           :ems_ref             => uid,
           :name                => instance.name,
-          :vendor              => "Microsoft",
+          :vendor              => "azure",
           :raw_power_state     => power_status(instance),
           :operating_system    => process_os(instance),
           :flavor              => series,
@@ -467,7 +467,7 @@ def parse_image(image)
           :ems_ref            => uid,
           :name               => uid.split(%r{Microsoft.Compute\/}i)[1].split('.').first,
           :location           => @ems.provider_region,
-          :vendor             => "microsoft",
+          :vendor             => "azure",
           :raw_power_state    => "never",
           :template           => true,
           :publicly_available => false,

db/fixtures/ae_datastore/ManageIQ/Cloud/VM/Retirement/StateMachines/Methods.class/__class__.yaml

@@ -131,12 +131,52 @@ object:
       on_error: 
       max_retries: 
       max_time: 
+  - field:
+      aetype: method
+      name: azure_meth1
+      display_name: Azure
+      datatype: string
+      priority: 7
+      owner: 
+      default_value: 
+      substitute: true
+      message: azure
+      visibility: 
+      collect: 
+      scope: 
+      description: 
+      condition: 
+      on_entry: 
+      on_exit: 
+      on_error: 
+      max_retries: 
+      max_time: 
+  - field:
+      aetype: relationship
+      name: azure_rel1
+      display_name: Azure
+      datatype: string
+      priority: 8
+      owner: 
+      default_value: 
+      substitute: true
+      message: azure
+      visibility: 
+      collect: 
+      scope: 
+      description: 
+      condition: 
+      on_entry: 
+      on_exit: 
+      on_error: 
+      max_retries: 
+      max_time: 
   - field:
       aetype: relationship
       name: common_rel1
       display_name: Common
       datatype: string
-      priority: 7
+      priority: 9
       owner: 
       default_value: 
       substitute: true
@@ -156,7 +196,7 @@ object:
       name: common_meth1
       display_name: Common
       datatype: string
-      priority: 8
+      priority: 10
       owner: 
       default_value: 
       substitute: true

db/fixtures/ae_datastore/ManageIQ/Cloud/VM/Retirement/StateMachines/Methods.class/__methods__/amazon_pre_retirement.rb

@@ -7,9 +7,9 @@
 if vm && vm.attributes['power_state'] == 'on'
   ems = vm.ext_management_system
   if vm.hardware.root_device_type == "ebs"
-    $evm.log('info', "Stopping Amazon Instance <#{vm.name}> in EMS <#{ems ? ems.name : nil}>")
+    $evm.log('info', "Stopping Amazon Instance <#{vm.name}> in EMS <#{ems.try(:name)}>")
     vm.stop if ems
   else
-    $evm.log('info', "Skipping stopping of non EBS Amazon Instance <#{vm.name}> in EMS <#{ems ? ems.name : nil}>")
+    $evm.log('info', "Skipping stopping of non EBS Amazon Instance <#{vm.name}> in EMS <#{ems.try(:name)}>")
   end
 end

db/fixtures/ae_datastore/ManageIQ/Cloud/VM/Retirement/StateMachines/Methods.class/__methods__/azure_pre_retirement.rb

@@ -0,0 +1,10 @@
+#
+# Description: This method stops the Azure Instance
+#
+
+vm = $evm.root['vm']
+if vm && vm.power_state == 'on'
+  ems = vm.ext_management_system
+  $evm.log('info', "Stopping Azure Instance <#{vm.name}> in EMS <#{ems.try(:name)}>")
+  vm.stop if ems
+end

db/fixtures/ae_datastore/ManageIQ/Cloud/VM/Retirement/StateMachines/Methods.class/__methods__/azure_pre_retirement.yaml

@@ -0,0 +1,12 @@
+---
+object_type: method
+version: 1.0
+object:
+  attributes:
+    name: azure_pre_retirement
+    display_name: 
+    description: 
+    scope: instance
+    language: ruby
+    location: inline
+  inputs: []

db/fixtures/ae_datastore/ManageIQ/Cloud/VM/Retirement/StateMachines/Methods.class/__methods__/openstack_pre_retirement.rb

@@ -5,6 +5,6 @@
 vm = $evm.root['vm']
 unless vm.nil? || vm.attributes['power_state'] == 'off'
   ems = vm.ext_management_system
-  $evm.log('info', "Suspending Openstack Instance <#{vm.name}> in EMS <#{ems ? ems.name : nil}")
+  $evm.log('info', "Suspending Openstack Instance <#{vm.name}> in EMS <#{ems.try(:name)}")
   vm.suspend if ems
 end

db/fixtures/ae_datastore/ManageIQ/Cloud/VM/Retirement/StateMachines/Methods.class/checkpreretirement.yaml

@@ -12,3 +12,5 @@ object:
       value: check_pre_retirement
   - amazon_meth1:
       value: amazon_check_pre_retirement
+  - azure_meth1:
+      value: check_pre_retirement

db/fixtures/ae_datastore/ManageIQ/Cloud/VM/Retirement/StateMachines/Methods.class/preretirement.yaml

@@ -12,3 +12,5 @@ object:
       value: openstack_pre_retirement
   - amazon_meth1:
       value: amazon_pre_retirement
+  - azure_meth1:
+      value: azure_pre_retirement

spec/automation/unit/method_validation/azure_pre_retirement_spec.rb

@@ -0,0 +1,24 @@
+require 'spec_helper'
+
+describe "azure_pre_retirement Method Validation" do
+  before do
+    @user = FactoryGirl.create(:user_with_group)
+    @zone = FactoryGirl.create(:zone)
+    @ems  = FactoryGirl.create(:ems_azure, :zone => @zone)
+    @vm   = FactoryGirl.create(:vm_azure,
+                               :name => "AZURE",   :raw_power_state => "VM Running",
+                               :ems_id => @ems.id, :registered => true)
+    @ins  = "/Cloud/VM/Retirement/StateMachines/Methods/PreRetirement"
+  end
+
+  it "call suspend for running instances" do
+    MiqAeEngine.instantiate("#{@ins}?Vm::vm=#{@vm.id}#Azure", @user)
+    MiqQueue.exists?(:method_name => 'stop', :instance_id => @vm.id, :role => 'ems_operations').should be_true
+  end
+
+  it "does not call suspend for powered off instances" do
+    @vm.update_attributes(:raw_power_state => 'VM Stopped')
+    MiqAeEngine.instantiate("#{@ins}?Vm::vm=#{@vm.id}#Azure", @user)
+    MiqQueue.exists?(:method_name => 'stop', :instance_id => @vm.id, :role => 'ems_operations').should be_false
+  end
+end

spec/models/manageiq/providers/azure/cloud_manager/refresher_spec.rb

@@ -140,7 +140,7 @@ def assert_specific_vm_powered_on
       :ems_ref_obj           => nil,
       :uid_ems               => "462f2af8-e67e-40c6-9fbf-02824d1dd485\\chef-prod"\
                                 "\\microsoft.compute/virtualmachines\\Chef-Prod",
-      :vendor                => "Microsoft",
+      :vendor                => "Azure",
       :power_state           => "on",
       :location              => "462f2af8-e67e-40c6-9fbf-02824d1dd485\\chef-prod"\
                                 "\\microsoft.compute/virtualmachines\\Chef-Prod",
@@ -235,7 +235,7 @@ def assert_specific_vm_powered_off_attributes(v)
       :ems_ref_obj           => nil,
       :uid_ems               => "462f2af8-e67e-40c6-9fbf-02824d1dd485\\computevms\\"\
                                 "microsoft.compute/virtualmachines\\MIQ2",
-      :vendor                => "Microsoft",
+      :vendor                => "Azure",
       :power_state           => "off",
       :location              => "462f2af8-e67e-40c6-9fbf-02824d1dd485\\computevms\\"\
                                 "microsoft.compute/virtualmachines\\MIQ2",
@@ -287,7 +287,7 @@ def assert_specific_template
       :uid_ems               => "https://chefprod5120.blob.core.windows.net/system/"\
                                 "Microsoft.Compute/Images/postgres-cont/"\
                                 "postgres-osDisk.fcf3dcec-fb8d-49f5-9d8c-b15edcff704c.vhd",
-      :vendor                => "Microsoft",
+      :vendor                => "Azure",
       :power_state           => "never",
       :location              => "eastus",
       :tools_status          => nil,