Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade RubyZip Gem to 1.2 #6938

Merged
merged 4 commits into from
Feb 29, 2016
Merged

Upgrade RubyZip Gem to 1.2 #6938

merged 4 commits into from
Feb 29, 2016

Commits on Feb 29, 2016

  1. Upgrade RubyZip Gem to 1.2 

    The rubyzip gem has been locked at 0.9.5 for 4 years due to a namespace conflict
caused by a change in 0.9.7.  The api changed in 1.0 and there are other gems that
rely on the new API, including winrm-fs, which is needed for winrm-elevated.

Adding gem ZipZip allows older api code to continue to function alongside code using
the newer api.

Spec tests against the new gem which failed with 0.9.7 pass.
    @jerryk55
    jerryk55 committed Feb 29, 2016
    Configuration menu
    Copy the full SHA
    9820dd3 View commit details
    Browse the repository at this point in the history

  2. Fix Test for Empty Zip File 

    The error message for an empty zip file has been changed between
rubyzip 0.9.5 and 1.2.0.  Fix the test to the correct message.
    @jerryk55
    jerryk55 committed Feb 29, 2016
    Configuration menu
    Copy the full SHA
    8090f60 View commit details
    Browse the repository at this point in the history

  3. Set Zip Entry Utime Correctly 

    The interface to change the utime on an entry in a zipfile has
changed between RubyZip 0.9.5 and 1.2.

Instead of calling zip.add with a filename and zip.file.utime with a File.mtime,
convert the mtime to a Zip::DOSTime, and create a new Zip Entry, setting the
time on the entry initializer.  Then call zip.add with the Entry rather than the name.
    @jerryk55
    jerryk55 committed Feb 29, 2016
    Configuration menu
    Copy the full SHA
    46155b3 View commit details
    Browse the repository at this point in the history

  4. Adjust VMDB::Util spec tests for add_zip_entry 

    Modify tests for add_zip_entry to coincide with changes
required when updating from RubyZip 0.9.5 to 1.2.0.
    @jerryk55
    jerryk55 committed Feb 29, 2016
    Configuration menu
    Copy the full SHA
    93766ab View commit details
    Browse the repository at this point in the history