Decide default destination folder for cloning

[bzwei]

https://bugzilla.redhat.com/show_bug.cgi?id=1313067

[chessbyte]

@bzwei In a separate PR, can we create a similar dest_resource_pool method and move all this logic there?

[bzwei]

@chessbyte yes sir 👌

[gmcculloug]

@bzwei VMware provisioning requires that a folder be passed so my concern is that the "Discovered virtual machine" folder may not exist for some reason. In that case we should drop back to use the root vm folder.

I think the lookup logic should be move into a new method that we can call with each path and it would return the folder or nil.

Something like:
vm_folder = "Datacenters/#{host_dc.name}/vm"
find_dest_folder("#{vm_folder}/Discovered virtual machine") || find_dest_folder(vm_folder)

[gmcculloug]

@bzwei This PR should also include the removal of the set_folder logic in
vmware_best_fit_least_utilized.rb#L8

[bzwei]

@gmcculloug I removed set_folder in the best_fit code.

[gmcculloug]

@bzwei The failing tests are in a context ("Auto placement #set_folder") that is no longer needed since the method is not setting the folder. The let(:vm_folder) is no longer needed in that method as well.

[miq-bot]

Checked commit bzwei@c755248 with ruby 2.2.3, rubocop 0.37.2, and haml-lint 0.16.1
98 files checked, 5 offenses detected

spec/automation/unit/method_validation/vmware_best_fit_least_utilized_spec.rb

• 🔶 - Line 24, Col 22 - Performance/TimesMap - Use Array.new with a block instead of .times.collect.
• 🔶 - Line 26, Col 17 - Performance/TimesMap - Use Array.new with a block instead of .times.collect.
• 🔶 - Line 58, Col 88 - Style/Semicolon - Do not use semicolons to terminate expressions.
• 🔹 - Line 30, Col 121 - Metrics/LineLength - Line is too long. [131/120]
• 🔹 - Line 31, Col 121 - Metrics/LineLength - Line is too long. [131/120]