Remove extra_js from ExplorerPresenter #7223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinpovolny
force-pushed
the
remove_extra_js
branch
from
a0537e9
to
32bc6c4
Compare
martinpovolny
changed the title
|
Checked commits martinpovolny/manageiq@4dba655~...da1d461 with ruby 2.2.3, rubocop 0.37.2, and haml-lint 0.16.1 |
dclarizio
pushed a commit
that referenced
this pull request
Mar 16, 2016
Remove extra_js from ExplorerPresenter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
extra_jsfrom ExplorerPresenter.After this is merged, we can switch from generating JavaScript to generating JSON, move the bits of logic to client-side removing this huge use or the
eval.