[WIP] Retirement - use datetime instead of date, mention server timezone #7471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
affects vms, orchestration_stacks and services
looks like `ManageIQ.timezone = {name: "Berlin", utc_offset: 3600}`
.in_time_zone can convert Date, Time, DateTime and String
…ement set on #{retires_on}"
+- details
makes retires_on_date function useless
…(or Time.now.to_date) + removed retires_on_date()
|
Checked commits https://github.com/himdel/manageiq/compare/08f26676953388920bb6eda2a2837203a676acb2~...65fa66327f3271d4980a6ff369443f7df8654567 with ruby 2.2.3, rubocop 0.37.2, and haml-lint 0.16.1 app/models/mixins/retirement_mixin.rb
spec/models/miq_expression/miq_expression_spec.rb
|
|
<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush. |
|
@himdel added the migration flag as this needs to get in before next Mon to make the E release |
|
@dclarizio #11156 is the new one with just the migration.. |
|
Please extract UI parts of this PR into https://github.com/ManageIQ/manageiq-ui-classic |
|
All the non-UI changes have been done in #11156, closing. A UI PR will follow :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1316632
@miq-bot add_label wip
EDIT: splitting off - migration first, in #11156