[WIP] Removed Automate/Simulation resolve_form from the sidebar's left_div #8178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@epwinchell somehow the left sidebar can not be scrollbale in the way we want it, so this was the only acceptable solution |
skateman
changed the title
|
Checked commit skateman@cfebff3 with ruby 2.2.3, rubocop 0.37.2, and haml-lint 0.16.1 |
|
cc @himdel |
| - content_for :left do | ||
| = render :partial => "resolve_form" | ||
| = render :partial => "resolve_form_buttons" | ||
|
|
||
| #main_div |
There was a problem hiding this comment.
Should probably move #main_div to resolve, not _resolve .. because _resolve is included from show and resolve, and show already does have #main_div...
|
This is wrong on so many levels...closing it 😢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
https://bugzilla.redhat.com/show_bug.cgi?id=1297030