Update permissions template #8200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fryguy
force-pushed
the
update_permissions_template
branch
from
2c22add
to
9ac03b0
Compare
Also sorted it because it was impossible to compare otherwise. The actual added values are - ems-type:ansible_tower_configuration - ems-type:azure_network - ems-type:ec2_network - ems-type:hawkular
Fryguy
force-pushed
the
update_permissions_template
branch
from
9ac03b0
to
bdcfb60
Compare
|
Checked commits Fryguy/manageiq@e0c0032~...bdcfb60 with ruby 2.2.3, rubocop 0.37.2, and haml-lint 0.16.1 |
|
LGTM, I'm not sure how to test for other out of date features. |
Fryguy
pushed a commit
that referenced
this pull request
Apr 25, 2016
Update permissions template (cherry picked from commit 74e87d9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I sort of need this as a pre-req for #8192 mainly so we don't get conflicts when backporting. This PR adds a spec verifying that the permissions.tmpl.yml is always up to date at least for the
ems-typeparts. I'm not sure how to add a spec for the rest of the permissions file.@chessbyte @jrafanie Please review. Sorry the diff is so nasty... the second commit is really the meat of the change. the first commit is a test refactoring, so I didn't have to copy/paste all of the setup for stubbing permissions.yml over to the ext_management_systems_spec.rb. The setup is quite a bit and it was ridiculous to copy over.