Automate - Add /System/Process/MiqEvent instance. #9336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinaafitz
changed the title
tinaafitz
changed the title
| description: | ||
| fields: | ||
| - rel5: | ||
| value: "/System/Event/MiqEvent/Policy/${/#event_type}" |
There was a problem hiding this comment.
@tinaafitz I think you want the relationship to be more like the Request instance in the Process class which uses
/System/Request/${#request}
Here I would expect it to be: /System/Event/MiqEvent/Policy/${/#request}
Then in your example you would specify the request (which your screenshot shows) but you do not have to pass duplicate data in the Attribute/Value Pairs.
Does that work better here?
The new MiqEvent instance enables a user to create custom buttons for our MiqEvents. https://bugzilla.redhat.com/show_bug.cgi?id=1348605
tinaafitz
force-pushed
the
new_process_miqevent
branch
from
ceb4891
to
fb5116a
Compare
|
@gmcculloug I used event_type to be consistent with the event instance, but agree that "request" makes more sense here. Change made. |
|
Checked commit tinaafitz@fb5116a with ruby 2.2.4, rubocop 0.37.2, and haml-lint 0.16.1 |
chessbyte
pushed a commit
that referenced
this pull request
Jul 5, 2016
Automate - Add /System/Process/MiqEvent instance. (cherry picked from commit 3ebe1ef)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new MiqEvent instance enables a user to create custom buttons and use simulate for MiqEvents.
https://bugzilla.redhat.com/show_bug.cgi?id=1348605