Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Dialog Editor styling issues #293

Merged
merged 1 commit into from
May 18, 2018
Merged

Fix Dialog Editor styling issues #293

merged 1 commit into from
May 18, 2018

Conversation

epwinchell
Copy link
Contributor

This PR is a follow-up to ManageIQ/manageiq-ui-classic#3668 and addresses the following requests:

  • correctly applies form-horizontal class for label positioning
  • decrease size of label column
  • increase size of text area
  • decrease size of dropdowns
  • move refresh button below text area

https://bugzilla.redhat.com/show_bug.cgi?id=1553697

Old (Classic UI)
screen shot 2018-03-27 at 2 22 15 pm

New (Classic UI)
screen shot 2018-03-27 at 2 20 51 pm

Old (Classic UI)
screen shot 2018-05-02 at 12 55 48 pm

New (Classic UI)
screen shot 2018-05-03 at 10 25 26 am

Old (Service UI)
screen shot 2018-04-11 at 1 38 03 pm

New (Service UI)
screen shot 2018-04-11 at 1 07 21 pm

@epwinchell
Copy link
Contributor Author

@miq-bot add_label bug, gaprindashvili/yes

@epwinchell
Copy link
Contributor Author

@miq-bot assign @himdel

@epwinchell
Copy link
Contributor Author

@himdel pls test

@himdel himdel mentioned this pull request May 3, 2018
Closed
@miq-bot
Copy link
Member

miq-bot commented May 3, 2018

Checked commit https://github.com/epwinchell/ui-components/commit/a8213098ccee66ea1335dc65202c8b476b36c956 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@himdel
Copy link
Contributor

himdel commented May 18, 2018

LGMT, the html structure looks good, not seeing any breakage in ops or sui 👍

@himdel himdel merged commit 268a2f6 into ManageIQ:master May 18, 2018
@himdel himdel added this to the Sprint 86 Ending May 21, 2018 milestone May 18, 2018
@himdel himdel mentioned this pull request May 18, 2018
Merged
@himdel
Copy link
Contributor

himdel commented May 22, 2018

Backported to gaprindashvili:

commit 0fbe9eecd89762b03889adcd7730225164fd6ce9 (HEAD -> gaprindashvili)
Author: Martin Hradil <himdel@seznam.cz>
Date:   Fri May 18 16:02:00 2018 +0200

    Merge pull request #293 from epwinchell/dialog_editor_updates2
    
    Fix Dialog Editor styling issues
    
    (cherry picked from commit 268a2f69889d671ffef418bd4628778cd2914b4e)

@miq-bot add_label gaprindashvili/backported
@miq-bot remove_label gaprindashvili/yes

himdel added a commit that referenced this pull request May 22, 2018
@himdel
Merge pull request #293 from epwinchell/dialog_editor_updates2
0fbe9ee 
Fix Dialog Editor styling issues

(cherry picked from commit 268a2f6)
@himdel
Copy link
Contributor

himdel commented May 22, 2018

Released in 1.0.28

This was referenced May 22, 2018
Merged
Merged
@epwinchell epwinchell mentioned this pull request Jul 16, 2018
Merged
@epwinchell epwinchell deleted the dialog_editor_updates2 branch December 13, 2018 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@himdel himdel

Labels
bug gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@epwinchell @miq-bot @himdel