Fix for dynamic dialog fields not being updated

[romanblanco]

Using dialogField.value for fields that are not a subclass of DialogFieldSortedItem.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1696474

[miq-bot]

Checked commits romanblanco/ui-components@633df92~...fefaf0c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

[romanblanco]

@d-m-u or @eclarizio, could you verify the fix works?

[romanblanco]

@miq-bot add_label bug, hammer/yes

[d-m-u]

thanks, looks great

[h-kataria]

@himdel @martinpovolny can you please merge this PR

[eclarizio]

Looks fine overall, surprised the small change in logic didn't break any specs though, I guess we don't have specs covering the changesHappened method for when the field type is DialogFieldRadioButton?

[simaishi]

Hammer backport details:

$ git log -1
commit 7bca0ba748ef1cb0ad73d80b2ab143ca71b57ae6
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Wed Apr 10 18:52:25 2019 +0200

    Merge pull request #381 from romanblanco/bz1696474
    
    Fix for dynamic dialog fields not being updated
    
    (cherry picked from commit a9c4a08d4856dcde41839260f2db91fddee74777)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1698586

[d-m-u]

Can we change

ui-components/src/dialog-user/services/dialogData.ts

Line 140 in 7bca0ba

const fieldValue = (value ? value : field.default_value);

to use the value rather than the default_value?

[himdel]

@d-m-u So, something like..

const fieldValue = (value !== undefined) ? value :
  ((field.values !== undefined) ? field.values : field.default_value);

?

EDIT: values

[h-kataria]

@romanblanco cc