Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert ng-model changes from #381 #382

Merged
merged 1 commit into from
Apr 11, 2019
Merged

Conversation

eclarizio
Copy link
Member

@eclarizio eclarizio commented Apr 11, 2019

After some deliberation, we decided it doesn't really make sense to change the ng-model designation since "values" doesn't make sense for a non sorted field that doesn't actually have a list of multiple values. Instead, the ng-model changes will be reverted and we will ensure the back end passes through the "default_value" properly for dynamic non sorted fields. That PR can be found here

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1698586

/cc @himdel

@miq-bot miq-bot added the wip label Apr 11, 2019
@miq-bot
Copy link
Member

miq-bot commented Apr 11, 2019

Checked commit eclarizio@09420c5 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@eclarizio eclarizio changed the title [WIP] Revert ng-model changes from #381 Revert ng-model changes from #381 Apr 11, 2019
@miq-bot miq-bot removed the wip label Apr 11, 2019
@himdel himdel self-assigned this Apr 11, 2019
@himdel himdel added this to the Sprint 109 Ending Apr 15, 2019 milestone Apr 11, 2019
@himdel himdel merged commit 7c13a67 into ManageIQ:master Apr 11, 2019
himdel added a commit that referenced this pull request Apr 12, 2019
Revert ng-model changes from #381

(cherry picked from commit 7c13a67)
@himdel
Copy link
Contributor

himdel commented Apr 12, 2019

Backported to hammer:

commit 95b6155a6de1be81203df61ff2b1bd70a44a8f18 (HEAD -> hammer, upstream/hammer)
Author: Martin Hradil <himdel@seznam.cz>
Date:   Thu Apr 11 21:29:29 2019 +0000

    Merge pull request #382 from eclarizio/quick_bz_fix
    
    Revert ng-model changes from #381
    
    (cherry picked from commit 7c13a67aa52823c7e83ac629402cb619dddc5d3f)

@miq-bot add_label hammer/backported
@miq-bot remove_label hammer/yes

(Cc @simaishi)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants