Fix several bugs with undocumented feature of Bass.PluginLoad() #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first bug here is with path handling. The code splits the directory name from the file name then merges them together but does not put a file seperator between the two. The second bug is with the state that it leaves Bass.LastError in after trying to load the plugin. If the plugin fails for any reason such as Errors.FileFormat, or Errors.Already that will get overwritten by later calls for the different platforms.
|
@MathewSachin Should be ready to review again when you have the chance |
DustinBond
approved these changes
Feb 25, 2021
MathewSachin
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So Bass.PluginLoad has an undocumented feature here where if you pass in the folder path + base name of the plugin it will add the file extension and prefixes for each platform and try each to see if any will load a valid plugin but i have found several issues with this:
The first bug here is with path handling. The code splits the directory name from the file name then merges them together but does not put a file separator between the two.
The second bug is with the state that it leaves Bass.LastError in after trying to load the plugin. If the plugin fails for any reason such as Errors.FileFormat, or Errors.Already that will get overwritten by later calls for the different platforms and the user will be unable to see why the plugin actually failed to load.