Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release 1.1.3 #158

Closed
3 tasks done
Valdnet opened this issue Nov 8, 2021 · 39 comments
Closed
3 tasks done

New release 1.1.3 #158

Valdnet opened this issue Nov 8, 2021 · 39 comments

Comments

@Valdnet
Copy link
Collaborator

Valdnet commented Nov 8, 2021

Tasks to be performed for version 1.1.3:

  • Application tests
  • Application translations
  • Milestone

@ManeraKai I think it's time to release a new version with fixed bugs and additional features 馃槈.

@Valdnet
Copy link
Collaborator Author

Valdnet commented Nov 9, 2021

@ManeraKai I think you can update the translation from POEditor if there is a new one and release a new version. Issue #61 has been shifted for v1.1.4 for an obvious reason 馃槈.

@ManeraKai
Copy link
Owner

I did update POEditor a few days ago, I should check it again though. I'll release a new version once I finish my exams. 3 left for 3 days.

@ManeraKai
Copy link
Owner

Did a scan to clean the code. Updated translations. Fixed bugs. Almost ready. Any bug on your side @Valdnet?

@ManeraKai
Copy link
Owner

https://github.com/ManeraKai/simplytranslate_mobile/actions/runs/1456830351

@Valdnet
Copy link
Collaborator Author

Valdnet commented Nov 13, 2021

The icon for a light theme should be of a different color. Currently confusing the user a bit.

@ManeraKai
Copy link
Owner

Any suggestion?

@Valdnet
Copy link
Collaborator Author

Valdnet commented Nov 13, 2021

Maybe yellow?

@ManeraKai
Copy link
Owner

Yellow doesn't contrast at all with white, I think I tried that, works well with dark mode though.

@ManeraKai
Copy link
Owner

A dimmed yellow maybe?

ManeraKai added a commit that referenced this issue Nov 13, 2021
@ManeraKai
Copy link
Owner

https://github.com/ManeraKai/simplytranslate_mobile/actions/runs/1457412702

@Valdnet
Copy link
Collaborator Author

Valdnet commented Nov 14, 2021

You need to change the font color in the theme picker for dark theme.

@ManeraKai
Copy link
Owner

@Valdnet
Copy link
Collaborator Author

Valdnet commented Nov 14, 2021

Error build.

@ManeraKai
Copy link
Owner

Idk what's wrong, reran it: https://github.com/ManeraKai/simplytranslate_mobile/actions/runs/1458880402

@Valdnet
Copy link
Collaborator Author

Valdnet commented Nov 14, 2021

There are 4 strings in POEditor that have no text to translate:

obraz

@ManeraKai
Copy link
Owner

They are not in the .arb files, I'll fix them but they don't have an effect on our release I think.

@Valdnet
Copy link
Collaborator Author

Valdnet commented Nov 14, 2021

Change the font color from black to white in the theme selector for the dark theme:

obraz

ManeraKai added a commit that referenced this issue Nov 14, 2021
@ManeraKai
Copy link
Owner

Fixed.

@Valdnet
Copy link
Collaborator Author

Valdnet commented Nov 14, 2021

These text strings should be added to the translation:

@ManeraKai
Copy link
Owner

ManeraKai commented Nov 14, 2021

They're brand names. i.e: Buy me a coffee has it's domain name as https://www.buymeacoffee.com/

@Valdnet
Copy link
Collaborator Author

Valdnet commented Nov 14, 2021

Can there be Arabic letters or a text string as RTL in other languages, such as Arabic?

@ManeraKai
Copy link
Owner

ManeraKai commented Nov 14, 2021

Your right, checked https://www.buymeacoffee.com/, didn't have an Arabic name. Checked https://liberapay.com/, it has an Arabic name 賱賷亘乇丕 亘丕賷

ManeraKai added a commit that referenced this issue Nov 14, 2021
@Valdnet
Copy link
Collaborator Author

Valdnet commented Nov 14, 2021

I would also add: Buy me a coffee. It is not known how it occurs in other languages 馃槈.

@ManeraKai
Copy link
Owner

It's untranslated now in their website. If it gets translated, I'll added it 馃憤

@Valdnet
Copy link
Collaborator Author

Valdnet commented Nov 14, 2021

Still need to change to about_screen.dart.

@ManeraKai
Copy link
Owner

oh I forgot.

@ManeraKai
Copy link
Owner

Fixed.

@ManeraKai
Copy link
Owner

@Valdnet I'll release the version. Hope you're still alive.

@Valdnet
Copy link
Collaborator Author

Valdnet commented Nov 17, 2021

@ManeraKai Of course, release the new version 馃憤.

Hope you're still alive.

I am 馃槈.

@Aga-C
Copy link
Contributor

Aga-C commented Nov 17, 2021

Well done, guys 馃檪
BTW. The website is really nice too 馃憤

@Valdnet
Copy link
Collaborator Author

Valdnet commented Nov 21, 2021

Yesterday a new version of the application was released 馃榿.

Well done, guys

@Aga-C Thanks 馃槈.

@ManeraKai
Copy link
Owner

ManeraKai commented Nov 21, 2021

And polish: https://f-droid.org/pl/packages/com.simplytranslate_mobile/
It looks off, zoom to 90% in a 1920:1080 display to make it look good.

@ManeraKai
Copy link
Owner

ManeraKai commented Nov 21, 2021

Talking about the web version of the f-droid site, it's totally ruined in the f-droid app.
context:

|--------------------|
| Talking about this |
|--------------------|

@Valdnet
Copy link
Collaborator Author

Valdnet commented Nov 21, 2021

It doesn't look good. I'd rather give it up.

@ManeraKai
Copy link
Owner

Sadly

@Valdnet
Copy link
Collaborator Author

Valdnet commented Nov 21, 2021

On the application page, you need to update the screenshots 馃槈.

@ManeraKai
Copy link
Owner

Yeah I noticed that. Updated them 3 days ago: 91a0f9e

@Valdnet
Copy link
Collaborator Author

Valdnet commented Nov 21, 2021

I'm talking about the screenshots on the website, not GitHub.

@ManeraKai
Copy link
Owner

Updated them: 55124ae

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants