New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select text #61
Comments
This is fixed. |
Request to reopen issue. Steps:
The selected long text also appears at the top of the application.
|
I noticed that, but I don't think it's a bug. I think it's how text toolbar generally works in android and flutter. It goes up to inform you where the real text selection is instead of just sticking to the border of the text field and misleading about where did you start your selection. The tear button is removed though as it won't be useful because you can't tweak selection without seeing the text. |
The text toolbar works as follows:
|
A good idea, but it won't work for a single word. The bar will be too high from the selected text. 1. All text selected:
2. Selection of one word or more than one word: The toolbar visibility coordinates should be set so that it should appear close to the selected single text, but if, after scrolling the text, when the selection hides beyond the boundaries of the editing window, the text toolbar should stay close to the border of the editing window.
|
No, I wrote that comment to show you that this is how Flutter's TextField works by default. Try to scroll more till the toolbar reach the top of the screen. It'll snap back down and slowly go up as you scroll more. It's really designed that way. |
It can't stay that way because it looks strange. I tested another application and the text editing bar works as expected. Maybe you need to give the text edit bar a condition: |
This problem is bothering me. This solution for the application is still missing. Is it possible to set only this field? When you move the application window while editing text, the toolbar goes completely outside the application boundaries. @ManeraKai Consider this issue again before releasing a new version 😉. |
2021-09-26.14-05-42.mp4 |
Now is good. Steps:
Maybe the solution would be to hide the text editing tool under the app banner to hide under it. Example: |
And the font color should be changed from black to white. |
It will be buggy. It should be added to the translated text widget too. Orientation and scrolling will break the fixed position numbers. I'm not confident to put it in this release at least. |
Well. Just yet change the font color for the text editing tool to white in light theme. |
Changed it. |
I am asking for a new test version and I am doing a general test of the application 😁. |
I am asking for a new version of the application. The current one does not contain @Aga-C changes. |
I am in favor of blocking application scrolling. When typing a translation, it is not needed. This will eliminate the problem with text editing tools leaving the application window. |
If you eliminate it, it will give an overflow problem. |
@Valdnet is the problem solved in the latest beta version?! https://github.com/ManeraKai/simplytranslate_mobile/actions/runs/2045778266 |
Here is it disabled: https://github.com/ManeraKai/simplytranslate_mobile/actions/runs/2047328527 |
@ManeraKai Have the changes been made or have you opted out of them? |
no I've disabled the |
In my opinion, it works incorrectly. It leaves the main application window. |
It just becomes hidden when the cursor leaves the screen right? |
The edit bar overlaps the top bar of the application. This is how it is done in other applications. |
Steps:
The selection menu with the "tear" is visible outside the text window:
The text was updated successfully, but these errors were encountered: