Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select text #61

Closed
Valdnet opened this issue Sep 20, 2021 · 126 comments
Closed

Select text #61

Valdnet opened this issue Sep 20, 2021 · 126 comments
Labels
bug Something isn't working
Milestone

Comments

@Valdnet
Copy link
Collaborator

Valdnet commented Sep 20, 2021

Steps:

  1. Enter a very long text.
  2. Select all text.

The selection menu with the "tear" is visible outside the text window:

obraz

@ManeraKai ManeraKai added the bug Something isn't working label Sep 20, 2021
@ManeraKai
Copy link
Owner

This is fixed.

@Valdnet
Copy link
Collaborator Author

Valdnet commented Sep 22, 2021

Request to reopen issue.
As an issue author, I still cannot open closed issues.

Steps:

  1. Enter long text.
  2. Select the text in its entirety.

The selected long text also appears at the top of the application.

obraz

  • The action selection window should appear either in the edit window or close to the edit window.
  • When scrolling through long text, the selection window should disappear and reappear near the window when you release your finger.

@ManeraKai
Copy link
Owner

the selection window should disappear and reappear

I noticed that, but I don't think it's a bug. I think it's how text toolbar generally works in android and flutter. It goes up to inform you where the real text selection is instead of just sticking to the border of the text field and misleading about where did you start your selection. The tear button is removed though as it won't be useful because you can't tweak selection without seeing the text.

@Valdnet
Copy link
Collaborator Author

Valdnet commented Sep 22, 2021

I noticed that, but I don't think it's a bug. I think it's how text toolbar generally works in android and flutter.

The text toolbar works as follows:

  1. Appears with selected text.
  2. If the selected text is long and does not fit in the text window, it appears underneath the window so as not to obscure the selected text.
  3. If you move your finger over the text, the text toolbar disappears as you move it and reappears in the same place.
  4. In your application, the toolbar moves with the text, which causes a strange visual effect.

@ManeraKai
Copy link
Owner

Here I've added a container with fixed hide to limit the size of the TextField. It doesn't obey:
image

@Valdnet
Copy link
Collaborator Author

Valdnet commented Sep 22, 2021

A good idea, but it won't work for a single word. The bar will be too high from the selected text.

1. All text selected:

  • The text toolbar above the edit window without changing its position when scrolling (see screenshot):

obraz

2. Selection of one word or more than one word:

The toolbar visibility coordinates should be set so that it should appear close to the selected single text, but if, after scrolling the text, when the selection hides beyond the boundaries of the editing window, the text toolbar should stay close to the border of the editing window.

  • Selected text at the top of the window:

obraz

  • Selected text at the top of the window after scrolling:

obraz

  • Selected text at the bottom of the window:

obraz

  • Selected text at the bottom of the window after scrolling:

obraz

@ManeraKai
Copy link
Owner

A good idea, but it won't work for a single word. The bar will be too high from the selected text.

No, I wrote that comment to show you that this is how Flutter's TextField works by default. Try to scroll more till the toolbar reach the top of the screen. It'll snap back down and slowly go up as you scroll more. It's really designed that way.

@Valdnet Valdnet reopened this Sep 23, 2021
@Valdnet
Copy link
Collaborator Author

Valdnet commented Sep 23, 2021

It can't stay that way because it looks strange. I tested another application and the text editing bar works as expected.

Maybe you need to give the text edit bar a condition:
e.g.:
Display the text editing bar from the selected text, e.g. 50px, but not higher (lower) than e.g. 100px from the window border.

@Valdnet
Copy link
Collaborator Author

Valdnet commented Sep 26, 2021

This problem is bothering me. This solution for the application is still missing.
After the tests, it turns out that the application takes the entire application field as text editing (marked in the screenshot).

obraz

obraz

Is it possible to set only this field?

obraz

When you move the application window while editing text, the toolbar goes completely outside the application boundaries.

obraz

@ManeraKai Consider this issue again before releasing a new version 😉.

@Valdnet Valdnet mentioned this issue Sep 26, 2021
6 tasks
@ManeraKai
Copy link
Owner

2021-09-26.14-05-42.mp4

ManeraKai pushed a commit that referenced this issue Sep 26, 2021
@ManeraKai
Copy link
Owner

https://github.com/ManeraKai/simplytranslate-flutter-client/actions/runs/1275126662

@Valdnet
Copy link
Collaborator Author

Valdnet commented Sep 26, 2021

Now is good.
Just to scroll the entire application window, hide the text editing tools under the top application banner.

Steps:

  1. Enter your text.
  2. Highlight the text.
  3. Move the entire application window up.

obraz

Maybe the solution would be to hide the text editing tool under the app banner to hide under it.

Example:

obraz

@Valdnet
Copy link
Collaborator Author

Valdnet commented Sep 26, 2021

And the font color should be changed from black to white.

@ManeraKai
Copy link
Owner

It will be buggy. It should be added to the translated text widget too. Orientation and scrolling will break the fixed position numbers. I'm not confident to put it in this release at least.

@Valdnet
Copy link
Collaborator Author

Valdnet commented Sep 26, 2021

Well. Just yet change the font color for the text editing tool to white in light theme.

ManeraKai pushed a commit that referenced this issue Sep 26, 2021
@ManeraKai
Copy link
Owner

Changed it.

@Valdnet
Copy link
Collaborator Author

Valdnet commented Sep 26, 2021

I am asking for a new test version and I am doing a general test of the application 😁.

@ManeraKai
Copy link
Owner

https://github.com/ManeraKai/simplytranslate-flutter-client/actions/runs/1275254538

@Valdnet
Copy link
Collaborator Author

Valdnet commented Sep 26, 2021

I am asking for a new version of the application. The current one does not contain @Aga-C changes.

@ManeraKai
Copy link
Owner

No problem: https://github.com/ManeraKai/simplytranslate-flutter-client/actions/runs/1275317938

@Valdnet
Copy link
Collaborator Author

Valdnet commented Sep 26, 2021

I am in favor of blocking application scrolling. When typing a translation, it is not needed. This will eliminate the problem with text editing tools leaving the application window.

@ManeraKai
Copy link
Owner

If you eliminate it, it will give an overflow problem.

ManeraKai pushed a commit that referenced this issue Oct 22, 2021
ManeraKai added a commit that referenced this issue Oct 22, 2021
ManeraKai added a commit that referenced this issue Oct 22, 2021
ManeraKai added a commit that referenced this issue Oct 22, 2021
ManeraKai added a commit that referenced this issue Oct 22, 2021
ManeraKai added a commit that referenced this issue Oct 22, 2021
ManeraKai added a commit that referenced this issue Oct 22, 2021
@Valdnet Valdnet modified the milestones: v1.1.3, v1.1.4 Nov 9, 2021
@Valdnet Valdnet mentioned this issue Nov 9, 2021
3 tasks
@Valdnet Valdnet modified the milestones: v1.1.4, v1.1.5 Jan 10, 2022
@ManeraKai
Copy link
Owner

@Valdnet is the problem solved in the latest beta version?! https://github.com/ManeraKai/simplytranslate_mobile/actions/runs/2045778266

@ManeraKai
Copy link
Owner

Here is it disabled: https://github.com/ManeraKai/simplytranslate_mobile/actions/runs/2047328527

@Valdnet
Copy link
Collaborator Author

Valdnet commented Mar 28, 2022

@ManeraKai Have the changes been made or have you opted out of them?

@ManeraKai
Copy link
Owner

no I've disabled the selection tool bar. It's now vanilla input you can say.

@Valdnet
Copy link
Collaborator Author

Valdnet commented Mar 29, 2022

In my opinion, it works incorrectly. It leaves the main application window.

@ManeraKai
Copy link
Owner

It just becomes hidden when the cursor leaves the screen right?

@Valdnet
Copy link
Collaborator Author

Valdnet commented Mar 29, 2022

The edit bar overlaps the top bar of the application.
I suggest that the selected text disappears when you scroll the text in the window. This will eliminate the problem of the edit bar leaving the main application window.

This is how it is done in other applications.

@Valdnet Valdnet modified the milestones: v1.2.1, v1.2.2 Apr 28, 2022
@Valdnet Valdnet modified the milestones: v1.3.1, v1.3.2 Jun 22, 2022
@ManeraKai ManeraKai closed this as not planned Won't fix, can't repro, duplicate, stale Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants