Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the possibility to use custom unit instead of px. #166

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JoMas971
Copy link

Hello,

In some cases, we need to use a custom unit instead of px (%, vw, em...). So i've updated the plugin and add the possibility to do so. By default, it will use 'px' like before.

Regards.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 70.588% when pulling bb20629 on ilanddev:master into 84fa330 on Mango:master.

@edgehero
Copy link

merge this one please, we need this

@bassplayer7
Copy link

This would be fantastic!

@niallobrien
Copy link

Can we get this branch merged please? Thanks in advance.

@pazguille
Copy link
Member

Hi @JoMas971, I like this feature, but it works weird when using touch events to open / close the slideout.

@Mrkisha
Copy link

Mrkisha commented Mar 2, 2017

this is very important feature. It would be nice if you would merge it. If not please what needs to be changed to meet your criteria for merging.

@andercard
Copy link

A function so necessary and that it does not merge is desecuting

@cssjunkie
Copy link

Hi @JoMas971, I like this feature, but it works weird when using touch events to open / close the slideout.

I've modded my slideout install locally and it appears to work fine with units. I'll see if I can do some testing on mobiles and isolate any problems. My guess is it's only bad in certain cases that might be avoided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants