Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for preventing opening menu when vertically scrolling #236

Closed
wants to merge 1 commit into from
Closed

Add support for preventing opening menu when vertically scrolling #236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ function Slideout(options) {

// Sets default values
this._startOffsetX = 0;
this._startOffsetY = 0;
this._currentOffsetX = 0;
this._opening = false;
this._moved = false;
Expand All @@ -81,6 +82,7 @@ function Slideout(options) {
this._tolerance = parseInt(options.tolerance, 10) || 70;
this._padding = this._translateTo = parseInt(options.padding, 10) || 256;
this._orientation = this._side === 'right' ? -1 : 1;
this._verticalRatio = options.verticalRatio || 2;
this._translateTo *= this._orientation;

// Sets classnames
Expand Down Expand Up @@ -219,6 +221,7 @@ Slideout.prototype._initTouchEvents = function() {
self._moved = false;
self._opening = false;
self._startOffsetX = eve.touches[0].pageX;
self._startOffsetY = eve.touches[0].pageY;
self._preventOpen = (!self._touch || (!self.isOpen() && self.menu.clientWidth !== 0));
};

Expand Down Expand Up @@ -261,13 +264,14 @@ Slideout.prototype._initTouchEvents = function() {
}

var dif_x = eve.touches[0].clientX - self._startOffsetX;
var dif_y = eve.touches[0].clientY - self._startOffsetY;
var translateX = self._currentOffsetX = dif_x;

if (Math.abs(translateX) > self._padding) {
return;
}

if (Math.abs(dif_x) > 20) {
if (Math.abs(dif_x) > 20 && Math.abs(dif_y) * this._verticalRatio <= Math.abs(dif_x)) {

self._opening = true;

Expand Down