Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add describeby text to user menu buttons #2026

Closed
SMaxOwok opened this issue Mar 14, 2019 · 0 comments
Closed

Add describeby text to user menu buttons #2026

SMaxOwok opened this issue Mar 14, 2019 · 0 comments
Labels
Type: Accessibility Issue relates to our goal of making manifold usable by as many people as possible. Type: Bug Issue represents a defect or error in Manifold.

Comments

@SMaxOwok
Copy link
Member

Buttons like the profile image button and the notification settings button must use aria-describedby = "" to describe what they do. In this case, SR users get none of the contextual information for the profile image button
@SMaxOwok SMaxOwok added Type: Bug Issue represents a defect or error in Manifold. Type: Accessibility Issue relates to our goal of making manifold usable by as many people as possible. labels Mar 14, 2019
SMaxOwok added a commit that referenced this issue Mar 14, 2019
@SMaxOwok
[B] Add describedby text to user menu buttons
1c78c14 
This also removes the click action from the user's name and adds a
notifications button to the mobile menu.

Fixes #2024
Fixes #2026
@SMaxOwok SMaxOwok mentioned this issue Mar 14, 2019
Merged
zdavis pushed a commit that referenced this issue Mar 15, 2019
@SMaxOwok @zdavis
[B] Add describedby text to user menu buttons
330a39f 
This also removes the click action from the user's name and adds a
notifications button to the mobile menu.

Fixes #2024
Fixes #2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Accessibility Issue relates to our goal of making manifold usable by as many people as possible. Type: Bug Issue represents a defect or error in Manifold.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SMaxOwok