Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed some typing hints. (ints to floats) #1154

Merged
merged 1 commit into from
Mar 22, 2021
Merged

Fixed some typing hints. (ints to floats) #1154

merged 1 commit into from
Mar 22, 2021

Conversation

cobordism
Copy link
Member

@cobordism cobordism commented Mar 22, 2021 •
edited by behackl
Loading

Motivation

I found some variables tagged as type int but I know they can take fractional values.

Overview / Explanation for Changes

I changed the typing hints.

Further Comments

Does python do anything with these typing hints, or are they decorative?

Acknowledgements

  • I have read the Contributing Guidelines
  • I have chosen a descriptive PR title (see top of PR template for examples)

Reviewer Checklist

  • Newly added functions/classes are either private or have a docstring
  • Newly added functions/classes have tests added and (optional) examples in the docs
  • Newly added documentation builds, looks correctly formatted, and adds no additional build warnings
  • The PR title is descriptive enough

behackl
behackl approved these changes Mar 22, 2021
View reviewed changes
Copy link
Member

@behackl behackl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@behackl behackl merged commit 196045b into ManimCommunity:master Mar 22, 2021
@cobordism cobordism deleted the typing_errors branch March 22, 2021 18:38
@jsonvillanueva jsonvillanueva added enhancement Additions and improvements in general documentation Improvements or additions to documentation and removed enhancement Additions and improvements in general labels Mar 23, 2021
@jsonvillanueva jsonvillanueva changed the title Fix some typing hints. (ints to floats) Fixed some typing hints. (ints to floats) Mar 24, 2021
@behackl behackl added this to the Release v0.5.0 milestone Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behackl behackl behackl approved these changes

@jsonvillanueva jsonvillanueva jsonvillanueva approved these changes

@naveen521kk naveen521kk naveen521kk approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
Release v0.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@cobordism @behackl @jsonvillanueva @naveen521kk