-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CLI bugs #1431
Fix CLI bugs #1431
Conversation
Fixed output_file option Removed -h help flag from manim/manim render
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Read the code, LGTM. (Didn't test locally yet, if someone else manages to use these changes successfully, we can merge it.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing I noticed, please have a look. I think we can merge this after this discussion is resolved.
Co-authored-by: Benjamin Hackl <devel@benjamin-hackl.at>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Changelog / Overview
-f
which was previously assigned to both--show_in_file_browser
and--format
by removing-f
from--format
. A warning is issued that-f
will soon move to--format
.--format
.--output_file
/-o
option.-qh
quality option was interpreted as-q
-h
, prompting the help page.Motivation
The format of the Scene(s) to render should be easily decidable under a single option:
-f
or--format
.As such, rendered media can now be selected via
manim -f png [FILE]
, or more explicitlymanim --format=gif [FILE]
Testing Status
Further Comments
It'd be nice to have this in the release so that we're not knowingly releasing a buggy new CLI, but I wish I had more time to implement test cases for this PR. If test cases are preferable, we can make a patch release later.
Checklist
Reviewer Checklist